The Bears Pit: Flugente's Magika Workshop » New feature: individual militia

Home » MODDING HQ 1.13 » Flugente's Magika Workshop » New feature: individual militia

Show: Today's Messages :: Polls :: Message Navigator

Re: New feature: individual militia[message #353107 is a reply to message #353094]

Fri, 13 April 2018 02:56

RunAwayScientist

Messages:84
Registered:September 2001

>does not return an ID if the profile does not exist. Does that compile?

Yes. It compiles and runs correctly. This is not good practice, I know, so perhaps you'd prefer a return null or 0? This function does not apparently require a return and terminates normally if no returned ID is provided. Your code is very robust.

> Second, if we do not have a profile, we need to create one, otherwise militia would be without it. So...

Nope, this is not required. What ends up happening is that if there is a problem or bug, it *will* create a new militia. This new militia ID orphans the old militia ID. This is how we get duplicated militia with orphan militia IDs that cannot be removed from savegames or dismissed. They are 'ghost' or 'phantom' IDs sitting in a vector. The game counts their salaries and results in a doubling of daily expenses. They *can* be dismissed manually, but this is annoying for the end user. They also /cannot/ be dismissed after their linked actual militia dies or disbands, resulting in stuck 'phantom' militia IDs in the save file that cannot be removed no matter what you do.

> As to the warnings...

Yes, I agree. This is good practice. However, a new variable should be used to measure the current computer clock time so that only *1* single debug message should be displayed every 30 minutes, or use in-game time for every day. This would cut back on the spam and still be a useful reminder to the player that they have unarmed militia.

For my games: I commonly smuggle in Kerberus militia into ports and docks and move them completely unarmed to reinforce current combat locations where I can give them equipment. This is how I encountered this issue.

@LatZee: If I understand the Kerberus code correctly, purchase prices are directly related to the settings in MilitiaIndividual.xml ; have you tried modifying those values and then going back to it? After I changed those values, I noticed that the purchase price for my Kerbs went up. I believe it's a hardcoded percentage or multiplier, but this can definitely be modified in the code or through the .xml to match the default prices.

I will pay.... a fair price.

[Updated on: Fri, 13 April 2018 03:05]

Report message to a moderator

Corporal 1st Class

[Message index]

		New feature: individual militia By: Flugente on Fri, 06 May 2016 17:32
		Re: New feature: individual militia By: silversurfer on Fri, 06 May 2016 18:00
		Re: New feature: individual militia By: Flugente on Fri, 06 May 2016 18:21
		Re: New feature: individual militia By: killerpfiffi on Fri, 06 May 2016 19:16
		Re: New feature: individual militia By: Panzer on Fri, 06 May 2016 21:30
		Re: New feature: individual militia By: Nasenbaer on Sat, 07 May 2016 15:58
		Re: New feature: individual militia By: killerpfiffi on Sun, 08 May 2016 13:02
		Re: New feature: individual militia By: Flugente on Sun, 08 May 2016 13:57
		Re: New feature: individual militia By: ratpaz on Fri, 20 May 2016 04:03
		Re: New feature: individual militia By: Flugente on Fri, 20 May 2016 21:54
		Re: New feature: individual militia By: ratpaz on Sat, 21 May 2016 21:47
		Re: New feature: individual militia By: Flugente on Sun, 22 May 2016 14:01
		Re: New feature: individual militia By: ratpaz on Sun, 22 May 2016 14:35
		Re: New feature: individual militia By: Flugente on Sun, 22 May 2016 15:21
		Re: New feature: individual militia By: Flugente on Mon, 23 May 2016 01:51
		Re: New feature: individual militia By: 3iff on Mon, 23 May 2016 10:06
		Re: New feature: individual militia By: ratpaz on Mon, 23 May 2016 14:51
		Re: New feature: individual militia By: 3iff on Wed, 25 May 2016 10:15
		Re: New feature: individual militia By: Flugente on Thu, 26 May 2016 02:59
		Re: New feature: individual militia By: 3iff on Thu, 26 May 2016 11:49
		Re: New feature: individual militia By: Uriens on Fri, 03 June 2016 13:24
		Re: New feature: individual militia By: Elvis_A on Wed, 06 July 2016 20:03
		Re: New feature: individual militia By: Flugente on Wed, 06 July 2016 20:12
		Re: New feature: individual militia By: Elvis_A on Wed, 06 July 2016 21:16
		Re: New feature: individual militia By: Flugente on Wed, 06 July 2016 21:36
		Re: New feature: individual militia By: Elvis_A on Wed, 06 July 2016 22:45
		Re: New feature: individual militia By: Flugente on Thu, 07 July 2016 20:11
		Re: New feature: individual militia By: ratpaz on Sun, 17 July 2016 00:30
		Re: New feature: individual militia By: Flugente on Sun, 17 July 2016 01:05
		Re: New feature: individual militia By: ratpaz on Sun, 17 July 2016 10:13
		Re: New feature: individual militia By: Flugente on Sun, 17 July 2016 12:19
		Re: New feature: individual militia By: Deleted. on Sun, 17 July 2016 13:35
		Re: New feature: individual militia By: DepressivesBrot on Sun, 17 July 2016 14:12
		Re: New feature: individual militia By: ratpaz on Sun, 17 July 2016 17:45
		Re: New feature: individual militia By: Flugente on Tue, 19 July 2016 12:59
		Re: New feature: individual militia By: Deleted. on Tue, 19 July 2016 14:01
		Re: New feature: individual militia By: ratpaz on Tue, 19 July 2016 14:33
		Re: New feature: individual militia By: Flugente on Tue, 19 July 2016 20:37
		Re: New feature: individual militia By: Flugente on Tue, 19 July 2016 20:51
		Re: New feature: individual militia By: ratpaz on Wed, 20 July 2016 07:46
		Re: New feature: individual militia By: Thor on Mon, 25 July 2016 20:25
		Re: New feature: individual militia By: Flugente on Mon, 25 July 2016 20:42
		Re: New feature: individual militia By: Thor on Tue, 26 July 2016 02:00
		Re: New feature: individual militia By: ratpaz on Tue, 02 August 2016 09:05
		Re: New feature: individual militia By: Flugente on Tue, 02 August 2016 13:14
		Re: New feature: individual militia By: Inukshuk on Tue, 02 August 2016 16:38
		Re: New feature: individual militia By: ratpaz on Tue, 02 August 2016 21:07
		Re: New feature: individual militia By: Uriens on Sun, 07 August 2016 20:25
		Re: New feature: individual militia By: Boojum on Fri, 02 September 2016 06:30
		Re: New feature: individual militia By: silversurfer on Fri, 02 September 2016 11:15
		Re: New feature: individual militia By: Boojum on Fri, 02 September 2016 19:19
		Re: New feature: individual militia By: silversurfer on Fri, 02 September 2016 23:22
		Re: New feature: individual militia By: Boojum on Sat, 03 September 2016 09:52
		Re: New feature: individual militia By: silversurfer on Sat, 03 September 2016 11:14
		Re: New feature: individual militia By: Enneagon on Sat, 03 September 2016 13:47
		Re: New feature: individual militia By: Boojum on Sat, 03 September 2016 19:48
		Re: New feature: individual militia By: RunAwayScientist on Thu, 22 September 2016 00:42
		Re: New feature: individual militia By: Elvis_A on Mon, 05 February 2018 08:35
		Re: New feature: individual militia By: Flugente on Sun, 04 March 2018 23:16
		Re: New feature: individual militia By: RunAwayScientist on Sat, 12 November 2016 08:32
		Re: New feature: individual militia By: Flugente on Mon, 14 November 2016 01:04
		Re: New feature: individual militia By: RunAwayScientist on Wed, 28 December 2016 06:27
		Re: New feature: individual militia By: Vincent J. Claymore on Fri, 13 January 2017 15:51
		Re: New feature: individual militia By: Flugente on Fri, 13 January 2017 20:42
		Re: New feature: individual militia By: Vincent J. Claymore on Fri, 13 January 2017 21:30
		Re: New feature: individual militia By: Flugente on Fri, 13 January 2017 21:46
		Re: New feature: individual militia By: Vincent J. Claymore on Fri, 13 January 2017 21:56
		Re: New feature: individual militia By: Flugente on Fri, 13 January 2017 22:23
		Re: New feature: individual militia By: Vincent J. Claymore on Sat, 14 January 2017 01:54
		Re: New feature: individual militia By: Flugente on Sat, 14 January 2017 02:22
		Re: New feature: individual militia By: Vincent J. Claymore on Sat, 14 January 2017 02:29
		Re: New feature: individual militia By: Flugente on Sat, 14 January 2017 02:34
		Re: New feature: individual militia By: Vincent J. Claymore on Sat, 14 January 2017 02:48
		Re: New feature: individual militia By: Flugente on Sat, 14 January 2017 02:53
		Re: New feature: individual militia By: Hawkeye on Sun, 15 January 2017 04:08
		Re: New feature: individual militia By: Zero Ziat on Wed, 25 January 2017 07:53
		Re: New feature: individual militia By: Flugente on Wed, 25 January 2017 21:19
		Re: New feature: individual militia By: Zero Ziat on Wed, 25 January 2017 23:19
		Re: New feature: individual militia By: Hawkeye on Sat, 14 January 2017 02:59
		Re: New feature: individual militia By: Vincent J. Claymore on Sat, 14 January 2017 13:27
		Re: New feature: individual militia By: RunAwayScientist on Fri, 05 May 2017 16:11
		Re: New feature: individual militia By: RunAwayScientist on Sat, 06 May 2017 01:24
		Re: New feature: individual militia By: RunAwayScientist on Mon, 18 September 2017 11:11
		Re: New feature: individual militia By: Flugente on Thu, 21 September 2017 21:40
		Re: New feature: individual militia By: GiantBasher on Mon, 02 October 2017 05:29
		Re: New feature: individual militia By: Flugente on Thu, 05 October 2017 23:01
		Re: New feature: individual militia By: GiantBasher on Sat, 07 October 2017 03:05
		Re: New feature: individual militia By: RunAwayScientist on Mon, 13 November 2017 21:57
		Re: New feature: individual militia By: Shadow on Fri, 12 January 2018 23:59
		Re: New feature: individual militia By: LatZee on Thu, 22 March 2018 10:41
		Re: New feature: individual militia By: RunAwayScientist on Wed, 11 April 2018 08:00
		Re: New feature: individual militia By: Flugente on Thu, 12 April 2018 21:44
		Re: New feature: individual militia By: LatZee on Fri, 13 April 2018 02:50
		Re: New feature: individual militia By: RunAwayScientist on Fri, 13 April 2018 02:56
		Re: New feature: individual militia By: Flugente on Fri, 13 April 2018 03:39
		Re: New feature: individual militia By: Flugente on Sat, 14 April 2018 17:32
		Re: New feature: individual militia By: RunAwayScientist on Mon, 16 April 2018 18:49
		Re: New feature: individual militia By: Flugente on Thu, 19 April 2018 22:27
		Re: New feature: individual militia By: Jolly_Reaper on Sat, 21 April 2018 02:09
		Re: New feature: individual militia By: RunAwayScientist on Sat, 21 April 2018 15:13
		Individual Militia Bug Fix (DEV - 8551) By: RunAwayScientist on Wed, 11 April 2018 07:53

Previous Topic:	New feature: advanced repair/dirt system
Next Topic:	New (unofficial) mercs: The Ryder twins (Mass Effect: Andromeda)

Goto Forum:

-=] Back to Top [=-

Current Time: Sat Nov 30 09:27:11 GMT+2 2024

Total time taken to generate the page: 0.02010 seconds