Home » PLAYER'S HQ 1.13 » v1.13 General Gameplay Talk » RPC stay civilian
RPC stay civilian[message #350017] Sat, 10 June 2017 23:30 Go to next message
EL Pino
Messages:4
Registered:June 2017
Hi Bears,

Just started the newest version of v1.13, and it is sure great.
Youve done a great job on improving the game.

Have just one little trouble hpe you can help me with.
Some of the RPC stay civilian after recruiting (hamous and madddog so far)
They can move between enemys and shoot them without reconision of the enemy.
The names of the RPC are displayed in yellow.

So far i figgered out this is couse of a flag "soldier_covert_npc_special".
I dont know what that means, or if its posseble for me to edit a file wich makes the RPC detectable by the enemys again.

i play version v1.13 8401 with wf 6.07
insane, oldskills, scifi and tons of guns.
the other options are off.
Didnt manage to get a screenshot or save game in the post
Hope you can help me even without.
Re: RPC stay civilian[message #350020 is a reply to message #350017] Sun, 11 June 2017 03:19 Go to previous messageGo to next message
silversurfer

 
Messages:2194
Registered:May 2009
Those NPCs have the covert flag because they are locals so the enemy soldiers ignore them. They should stop to ignore them once they start to attack enemy soldiers. Did the enemy notice that you were attacking them? If not then the NPC will keep his disguise.

The issue sounds familiar from a bug with the robot which could previously get the covert flag and mow down enemies at will without them fighting back. Strange thing is that the robot didn't lose his flags which may explain your issue as well.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: RPC stay civilian[message #350024 is a reply to message #350020] Sun, 11 June 2017 12:07 Go to previous messageGo to next message
EL Pino
Messages:4
Registered:June 2017
OK thank you for clearing up.
The trouble is the mercs stay undetected.
Can walk near enemys and kill them undetected.
Or just wound them at point blanc, then they go prone instead of hostile.
So yes, its simular to the robot you discripe.
Dont have it yet but suspect it will act same way.

Have found the same behavour with Conrad.
The 4 Rebels at omerta dont have the issue. This also counts for dynamo and shank. These are working as normal RPC.
Can i edit an file to remove or edit the flag? or give the rpc same behavour as dynamo and shank? (supect when make RPC rebels they get shot up)


Re: RPC stay civilian[message #350028 is a reply to message #350024] Sun, 11 June 2017 13:56 Go to previous messageGo to next message
silversurfer

 
Messages:2194
Registered:May 2009
Looks like there is some check missing that makes NPCs lose their covert flag when they commit hostile acts. If Flugente would read this he would probably know directly where to look. If you have a savegame from a point directly before you shoot at some enemy with Hamous or Maddog this would help to debug it. Please upload that savegame to a free file hoster.

The rebels don't show this behaviour because they are rebels who don't get the covert flag to start with. They are enemies of Deidranna so they will always get shot at. There is no file to modify because the flags are hard coded for certain NPCs.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: RPC stay civilian[message #350030 is a reply to message #350028] Sun, 11 June 2017 14:36 Go to previous messageGo to next message
EL Pino
Messages:4
Registered:June 2017
Ok, thanks for explaining.

Hope you can open the save games this way.
Conrad is the new RPC here, so gues its only with him you can see where the check went wrong.

Am not allowed to post links, so requere bit of copy paste ;)

www.dropbox.com/s/4esnslz7szgcbiu/SaveGame06.sav?dl=0

www.dropbox.com/s/jq5rqcb5a0zchb1/SaveGame07.sav?dl=0
Re: RPC stay civilian[message #350038 is a reply to message #350030] Mon, 12 June 2017 14:23 Go to previous messageGo to next message
silversurfer

 
Messages:2194
Registered:May 2009
I used your savegame to debug the issue and here is what I found:

- You are playing with old trait system
- In "Soldier Control.cpp" function "SOLDIERTYPE::RecognizeAsCombatant" immediately returns if the new trait system is not in use. This is ok as there is no covered trait in the old trait system. However, this prevents any further checks to make the NPC lose his disguise which causes him to stay covered forever.
- Covered flags are assigned to NPCs on recruitment even if the new trait system is not used! <- Bug fixed in r8405

I'll leave function "SOLDIERTYPE::RecognizeAsCombatant" as it is so the game doesn't run all this code when the new trait system isn't active anyway. I added checks to the savegame loading function to remove incorrect flags from robots/vehicles in general and from NPCs if the old trait system is used. This will help players that have started a game with the bug active.

[Updated on: Mon, 12 June 2017 14:29]




Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: RPC stay civilian[message #350040 is a reply to message #350038] Mon, 12 June 2017 17:05 Go to previous messageGo to next message
EL Pino
Messages:4
Registered:June 2017
Thanks for the fast and good help with the issue.
Am realy glad for such good support on such an old game.
The way you explain it, sounds like you have found and fixed the real issue i had trouble with.

About the version "r8405". I do not very well know how this all works ;)
Should i get a new SCI of in this case the "unstabel version r8405" when it gets released.
Or can i find this fix, somwhere at the moment?
Re: RPC stay civilian[message #350041 is a reply to message #350040] Mon, 12 June 2017 17:58 Go to previous messageGo to next message
silversurfer

 
Messages:2194
Registered:May 2009
Currently I wouldn't use 8405 because in 8404 a new bug got introduced that makes grenade launchers not work anymore. Should be fixed soon(tm) and then you can use the next version.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: RPC stay civilian[message #350047 is a reply to message #350041] Mon, 12 June 2017 21:39 Go to previous message
silversurfer

 
Messages:2194
Registered:May 2009
The grenade launcher bug was quickly fixed (thanks Bob) and I uploaded an English 8407 exe here for testing. Feel free to use that until a new regular update is published by Depri.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Previous Topic: Correct version?
Next Topic: Help a old Newbie which mod to choose - which is the most fun right now?
Goto Forum:
  


Current Time: Fri Nov 24 11:31:10 EET 2017

Total time taken to generate the page: 0.01185 seconds