Home » MODDING HQ 1.13 » Flugente's Magika Workshop » New feature: individual militia
Re: New feature: individual militia[message #351013 is a reply to message #345324] Mon, 18 September 2017 11:11 Go to previous messageGo to next message
RunAwayScientist

 
Messages:73
Registered:September 2001



Hello Flugente,


Just to clarify: the errors and issues being encountered are with PMC and turned prisoner militia, where their profiles are being incorrectly created. Not sure if you tested with these functions, as I've yet to compile and play the latest trunk.



Re: New feature: individual militia[message #351085 is a reply to message #351013] Thu, 21 September 2017 21:40 Go to previous messageGo to next message
Flugente

 
Messages:3165
Registered:April 2009
Location: Germany
Hmm. As you've discovered, there was a mix up between soldier class and militia level. I'm not sure why, because at some point I was aware of that exact issue and used conversion functions. Weird.

Anyway, fixed in r8477. This also fixes any ranks when loading an older savegames, of course.



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


bug6.png  Re: New feature: individual militia[message #351153 is a reply to message #351085] Mon, 02 October 2017 05:29 Go to previous messageGo to next message
GiantBasher

 
Messages:32
Registered:July 2017
1. Bug Report: I trained militia in Chitzena. When viewing the Militia Overview website, it says that I have militia in Drassen (B13 & C13). I have not yet taken over Drassen, so that can't be possible. I also interrogated a prisoner and he defected to me. I disbanded him and the possible error message appeared ("POSSIBLE ERROR: NOT ENOUGH INDIVIDUAL MILITIA FOUND IN DISBANDINDIVIDUALMILITIA"). After disbanding all militia and dismissing all mercs, I confirmed that I am still paying for the militia which don't exist.

2. The saved game, screenshot, and JA 2 Options.ini, have been uploaded to drop box:
https://www.dropbox.com/sh/0a3o59qc8xhvwqs/AADxzHNfV9uWzGVF86qKLnP0a?dl=0

3. Advance time until 09:45. Read Enrico's email and open the Militia Overview Website. Sort by location and note the militia in Drassen. Close the laptop and go to the Strategic view. Enable the militia filter. Click on Chitzena and disband all militia. Note the error message. Dismiss Spike. Note the Daily Expenses remain above 0.

4. Running Windows 10, JA 2 1.13 build 8488 game directory 2391 (01 Oct 2017)
5. No Mods
Re: New feature: individual militia[message #351198 is a reply to message #351153] Thu, 05 October 2017 23:01 Go to previous messageGo to next message
Flugente

 
Messages:3165
Registered:April 2009
Location: Germany
I've fixed the appearance of that error message in r8493. But the militia profiles in Drassen already exist when one loads the savegame (it says they were trained in Drassen on Day 1, 16:00). I'm not sure where they come from though. As we completely wipe our individual militia every time we load a savegame, I don't think this could be some sort of saving/loading issue. Do you have another savegame from, like, a different campaing where these guys existed?



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


bug6.png  Re: New feature: individual militia[message #351214 is a reply to message #351198] Sat, 07 October 2017 03:05 Go to previous messageGo to next message
GiantBasher

 
Messages:32
Registered:July 2017
Flugente wrote on Thu, 05 October 2017 15:01
But the militia profiles in Drassen already exist when one loads the savegame (it says they were trained in Drassen on Day 1, 16:00). I'm not sure where they come from though. As we completely wipe our individual militia every time we load a savegame, I don't think this could be some sort of saving/loading issue. Do you have another savegame from, like, a different campaing where these guys existed?


I started a new campaign using 8488 game dir 2391. However, I saved over a previous saved game from an older campaign. I did not realize that overwriting a previous save would some how mix up the individual militia profiles. How does that work exactly?

If it helps with your analysis I have uploaded that other saved game to dropbox along with the INI (I happened to back up files prior to overwriting the save). Note that this saved game is from 8473 using game dir 2385.

https://www.dropbox.com/sh/5e03m3kksqlv8ya/AAApNJNxyNnmzRbgbmDR5Glna?dl=0
Re: New feature: individual militia[message #351473 is a reply to message #351214] Mon, 13 November 2017 21:57 Go to previous message
RunAwayScientist

 
Messages:73
Registered:September 2001


Dev Build - 8506


Hey Flug, bug report time:

So it appears the militia issue is almost fixed. The 'Individual Profile Duplication' bug and error message will still occur when you move a squad of militia or mobile militia into a sector that is currently loaded. It can be any sector. It happens with Kerberus or regular militia.


I have not tried reloading a bugged save to see if wiping the individual militia resolves duplicated profiles.


As long as you unload the sector from game memory by loading another sector before moving militia into it, you can avoid this bug in the current build (for now).

This is a C++ vector or variable scope issue, which is beyond my ability to fix or track down.

A very frustrating bug to figure out, for sure. Perhaps it would be better to not create a profile for a militia if it isn't found? For those with old saves, that means that only their new Kerberus or newly trained or defected militia would have profiles, but it might avoid the duplication bug. Thoughts?

[Updated on: Mon, 13 November 2017 22:00]


Previous Topic: New feature: advanced repair/dirt system
Next Topic: New feature: combat jeeps
Goto Forum:
  


Current Time: Thu Nov 23 01:40:38 EET 2017

Total time taken to generate the page: 0.01838 seconds