And first bug encountered - entering bloodcat lair starts combat with bloodcat turn, and turn progress gets stuck near the start, seemingly after the first bloodcat finishes action. I know there is 30 second timeout for AI and I know I saw it in action few times in the past, but this time it does not work. I tried the same save with regular ja2.exe, I immediately see a lot of bloodcats and they normally do their turn. With AI exe, I even do not get to see them (strangely).

I wonder what good people were making of x-ray so it felt like cheating. I guess I don't know something.. As I used it only for tactical planning, adding some noise to enemy positions would make no difference to me, as enemies could change position anyway till I move nearer to them. But if that helps with any other kind of cheating, it would be good solution as it would not hurt it's use for tactical planning. Fake spots I think would be more complicated as it would force use to try twice to deduce fakes - would be even worse.
About the bug, I have the save. I had to produce it again from earlier save in which hummer was moving into lair, and bug did not repeat. Then tried once more, and bug repeated. So I have the save with bug, and save before bug which may or may not reproduce bug (if that would help). Where I should upload or send saves?

And first bug encountered - entering bloodcat lair starts combat with bloodcat turn, and turn progress gets stuck near the start, seemingly after the first bloodcat finishes action. I know there is 30 second timeout for AI and I know I saw it in action few times in the past, but this time it does not work. I tried the same save with regular ja2.exe, I immediately see a lot of bloodcats and they normally do their turn. With AI exe, I even do not get to see them (strangely).

I just encountered the bloodcat freeze also in current version of AV. It freezes as the Bloodcat strikes. If you need another save I can send it.

Same here using latest AV, bloodcat ambushes tend to freeze on the second turn, only way to avoid it is by using cheats to kill them all.

@sevenfm

I like to play JA2+AI. Can provide Chinese version? Or provide source patch? Thanks.

----

In additon, I have question to consult you:

I recently in the correction "IoV MOD"(929beta). When hire AIM merc(eg. Reaper), Reaper's Gun is "Colt XM177-E2/XM-148 Combo"(define in MercStartingGear.xml). But Reaper lost his Gun. And when buy this gun from BR. This gun's ammo is lost(0 in mag).

I check "Colt XM177-E2/XM-148 Combo"'s ammo is: Caliber 5.56mm M193, Capacity 20. And I check Magazines.xml, this ammo have defined.

Then I use XML Editor.exe Check this gun and this ammo. No problem found. But this gun's ammo in Itemx.xml, uiIndex is 2098. When I use XML Editor to Change this ammo's uiIndex to < 1960(eg. 1000). Repear's gun is OK.

Then I check a lot of similar, it is need to change ammo's uiIndex below 1960 to work.

So, my question is: add Ammo to game, have any rules limit? how to avoid the definition of gun lost because of the magazine?

But I used ja2+AI.exe to play 1.13Statle + IoV, Without any problems.

Sorry for my poor English. Don't know whether you understand what I said.

@sevenfm

I like to play JA2+AI. Can provide Chinese version? Or provide source patch? Thanks.

----

In additon, I have question to consult you:

I recently in the correction "IoV MOD"(929beta). When hire AIM merc(eg. Reaper), Reaper's Gun is "Colt XM177-E2/XM-148 Combo"(define in MercStartingGear.xml). But Reaper lost his Gun. And when buy this gun from BR. This gun's ammo is lost(0 in mag).

I check "Colt XM177-E2/XM-148 Combo"'s ammo is: Caliber 5.56mm M193, Capacity 20. And I check Magazines.xml, this ammo have defined.

Then I use XML Editor.exe Check this gun and this ammo. No problem found. But this gun's ammo in Itemx.xml, uiIndex is 2098. When I use XML Editor to Change this ammo's uiIndex to < 1960(eg. 1000). Repear's gun is OK.

Then I check a lot of similar, it is need to change ammo's uiIndex below 1960 to work.

So, my question is: add Ammo to game, have any rules limit? how to avoid the definition of gun lost because of the magazine?

But I used ja2+AI.exe to play 1.13Statle + IoV, Without any problems.

Sorry for my poor English. Don't know whether you understand what I said.

Code change: When loading gun/looking for a default magazine for a gun while no mag with fitting magsize exists, instead take a magazine of same calibre and ammotype that has magsize bigger (but close to) the originally requested magsize.

// find item ID that uses found explosives entry
if(newItem > 0)
{
	for(UINT16 loop = 1; loop < MAXITEMS; loop++)
	{
		// sevenfm: removed optimization
		//if(Item[loop].uiIndex == 0)
		//	break;
		if(Item[loop].usItemClass & IC_GRENADE && Item[loop].ubClassIndex == newItem)
		{
			return Item[loop].uiIndex;
		}
	}
}

// WANNE: Now ammo can be inserted anywhere in Items.xml (before only on index > 70 [FIRST_AMMO] (fix by Realist)
//for (usLoop = FIRST_AMMO; usLoop < MAXITEMS; usLoop++)
for (usLoop = 0; usLoop < MAXITEMS; usLoop++)
{
	// sevenfm: check all items to prevent bug
	/*if ( Item[usLoop].usItemClass  == 0 )
	{
		DebugMsg( TOPIC_JA2, DBG_LEVEL_3, String( "MagazineClassIndexToItemType: breaking at index %d", usLoop ) );
		break;
	}*/
	if (Item[usLoop].ubClassIndex == usMagIndex && Item[usLoop].usItemClass == IC_AMMO )
	{
		DebugMsg( TOPIC_JA2, DBG_LEVEL_3, String( "MagazineClassIndexToItemType: return %d", usLoop ) );
		return( usLoop );
	}
}

for( i = 0; i < MAXITEMS; ++i )
{
	// sevenfm: remove optimization to prevent bug
	//if ( Item[i].usItemClass  == 0 )
	//	break;

	if( ValidLaunchable( i, launcherIndex ) && ItemIsLegal(i) && Item[i].ubCoolness <= lowestCoolness )
	{
		lowestCoolness = Item[i].ubCoolness;
	}
}

// WANNE: This should fix the hang on the merc positioning screen (fix by Razer)
//while( !usNumMatches )
{ //Count the number of valid launchables
	for( i = 0; i < MAXITEMS; ++i )
	{
		// sevenfm: remove optimization to prevent bug
		// ( Item[i].usItemClass  == 0 )
		//	break;

		//Madd: quickfix: make it not choose best grenades right away.
		if( ValidLaunchable( i, itemIndex ) && ItemIsLegal(i) && Item[i].ubCoolness <= max(HighestPlayerProgressPercentage()/10,lowestCoolness) )
			usNumMatches++;
	}
}

if( usNumMatches )
{
	usRandom = (UINT16)Random( usNumMatches );
	for( i = 0; i < MAXITEMS; ++i )
	{
		// sevenfm: remove optimization to prevent bug
		//if ( Item[i].usItemClass  == 0 )
		//	break;

		if( ValidLaunchable( i, itemIndex ) && ItemIsLegal(i) && Item[i].ubCoolness <= max(HighestPlayerProgressPercentage()/10,lowestCoolness) )
		{
			if( usRandom )
				usRandom--;
			else
			{
				return i;
			}
		}
	}
}

// Flugente: the above code is highly dubious.. why do we loop over all items 2 times, and why that obscure usRandom--; business? This can cause an underflow!
BOOLEAN isnight = NightTime();
UINT16 maxcoolness = max( HighestPlayerProgressPercentage() / 10, lowestCoolness );

std::vector<UINT16> legalvec;
for ( UINT16 i = 0; i < MAXITEMS; ++i )
{
	// sevenfm: remove optimization to prevent bug
	//if ( Item[i].usItemClass == 0 )
	//	break;

	//Madd: quickfix: make it not choose best grenades right away.
	if ( Item[i].ubCoolness <= maxcoolness && ItemIsLegal( i ) && ValidLaunchable( i, itemIndex ) )
	{
		// Flugente: ignore this item if we aren't allowed to pick it at this time of day
		if ( (isnight && Item[i].usItemChoiceTimeSetting == 1) || (!isnight && Item[i].usItemChoiceTimeSetting == 2) )
			continue;

		legalvec.push_back(i);
		++usNumMatches;
	}
}

Here's Chinese version of Ja2+AI, please let me know if it works:
https://www.dropbox.com/s/w77d0rpzirlcv5d/ja2_7609ch%2BAI_r314.exe?dl=0

There's a special patch in Ja2+AI to allow it to work with IoV929 mod.
There was a problem in mod with ammo magazines caused by search optimization in the code - the code stops searching magazine when it finds first item with usItemClass = 0, so there's probably an empty NADA item somewhere between magazines in items.xml, if you check all items and make sure they all have non-zero uiIndex and usItemClass, the magazines should start to work.
In Ja2+AI this optimization was removed, so it should work well with IoV929 or other mods with magazine problems.
I also added Flugente's r8312 fix from main trunk:...

Chinese version of Ja2+AI work well. If you can, update following files from 2014 source svn8341 for Chinese Version in next version of JA2+AI, Thanks.
Standard Gaming Platform/WinFont.cpp
Utils/_ChineseText.cpp

Any chance to port a couple of tested features to main branch any time soon?

Any chance to port a couple of tested features to main branch any time soon?

@sevenfm

Hi, I found ja2_7609ch+AI_r319.exe,ja2_7609ch+AI_r320.exe,ja2_7609ch+AI_r323.exe are not the latest _ChineseText.cpp. The svn7609 version haven't updated perfect translation of Chinese. So, Please use following _ChineseText.cpp to replace. (ja2_source_official_2014 svn8341). Thanks.
http://www.mediafire.com/file/4t23xi1hcz4c397/_ChineseText_113stable_source_svn8341.7z

Updated:
https://www.dropbox.com/s/zrykb37hd6g0mmx/ja2_7609ch%2BAI_r325.exe?dl=0

Is this Encoding problem?

//#define ENGLISH

#define CHINESE

I don't know.
What I do is comment ENGLISH

//#define ENGLISH

and uncomment CHINESE in Language Defines.h

#define CHINESE

As far as I know there are no problems with English and Russian versions, so I have no idea what happens with '%' char.

  <PropertyGroup Label="UserMacros">
    <JA2Config>JA2</JA2Config>
    <JA2LangPrefix>CN</JA2LangPrefix>
    <JA2Language>CHINESE</JA2Language>
  </PropertyGroup>

Hey guys, quick question: is it possible to implement the JA2+AI features into another mod that uses the same JA2113 stable such as UC113? If so, what would be the install order? I read a comment about UC113 in an earlier comment here yet cannot find instructions on how I would do it.

Have you had a chance to take a look at the Bloodcat Freeze issue? The latest JA2+AI (r325) I am experiencing freezes immediately upon entering the sector on a Bloodcat ambush.

Bummer! Is there a workaround?

Another bug. Impossible to collect royal jelly from queen (r299). Works correctly with original ja2.exe. When collecting jelly, there is an area on map which turns red when trying to collect. In original ja2.exe, the area is 3x3 square, and in ja2AI the area is only 1x1 square in the center of the original 3x3. That as I understand makes it impossible to reach it. Using Arulco Revisited mod, but I don't think it could be the root cause (except maybe changing the area where queen lies).

weidox wrote on Fri, 02 December 2016 21:41

Another bug. Impossible to collect royal jelly from queen (r299). Works correctly with original ja2.exe. When collecting jelly, there is an area on map which turns red when trying to collect. In original ja2.exe, the area is 3x3 square, and in ja2AI the area is only 1x1 square in the center of the original 3x3. That as I understand makes it impossible to reach it. Using Arulco Revisited mod, but I don't think it could be the root cause (except maybe changing the area where queen lies).

Can you provide a save with description, preferably just before the queen is killed?
I don't remember changing anything even close related to royal jelly and queen.
Also, it's better to update your ja2+AI version to at least r336 as old versions have some bugs.