Home » MODDING HQ 1.13 » v1.13 Bug Reports » Massive amounts of items in sectors becoming unreachable
Massive amounts of items in sectors becoming unreachable[message #333810]
|
Fri, 20 June 2014 18:38
|
|
easterngames |
|
Messages:28
Registered:April 2011 Location: Pennsylvania , USA |
|
|
V 7240.
About 30 hours into campaign, and throughout occasionally certain things would become unreachable in the campaign item screen. usually didn't matter all that much, but suddenly an entire sector stockpile is now flagged as all unreachable. The sector is G9.
I mention this because this sector has had other insane inventory anomalies before. Once the sector began spawning all the items that were in the drassen airport sector, only multiplying it every time I opened the window. 2x, 3x, 4x. Luckily I had just reloaded a recent savegame and it went back to normal.
Unfortunately the locked item problem happened after half a dozen brutal defense battles and whatnot, and the closet save when its not a problem is days earlier. Is there anyway to force the items to unlock?
But at any rate, this sector seems to be having inventory problems.
Report message to a moderator
|
Private 1st Class
|
|
|
|
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #333885]
|
Wed, 25 June 2014 19:55
|
|
Buggler |
|
Messages:211
Registered:November 2009 |
|
|
Gorro der Gr
[Updated on: Thu, 26 June 2014 03:58] by Moderator Report message to a moderator
|
Sergeant 1st Class
|
|
|
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #344321 is a reply to message #344248]
|
Wed, 02 March 2016 10:54
|
|
3iff |
|
Messages:65
Registered:July 2001 Location: Birmingham, UK |
|
|
Unreachable items, further research.
I continued my game having eliminated some "unreachable items" in G8 after reverting to an earlier save.
My strategy was to stop "getitem" commands if possible and to stop ctrl-clicking items from merc to sector inventory. This essentially worked. I didn't have any bad items at all so I got adventurous.
Dimitri was in H2 and I used him to "getitems" from H3, no problem. So I had him clear G2 and G1. This is where I found some bad items. I reverted to an earlier save and tried again. He cleared G2 and all was good. He then cleared G1 and again no problems. H1 also got cleared without bad items. The only difference from earlier was that I checked H2 after clearing each neighbour sector. Dimitri was the only person in any of those sectors and so I don't believe there could be any interference from other sources.
So, the only conclusion I can draw is that "getitems" is fine but there's some issue when items are added to the sector inventory and it's intermittent or it's when a new item (new/unique to that sector) need to have a slot created for it...or the number of unique items in a sector hits a certain level.
Another thing I spotted, not sure whether it's by design or not.
If a merc in a sector drops an object on the map, the item appears (obviously) and can be picked up from the map. If the merc is on the strategic map and moves an item from himself to the sector inventory, then pops into the sector map, the object he just dropped is visible next to him but cannot be picked up from the map. It's as if the transferred object is out of phase with the map and the merc. When looking at the object via the sector inventory, the object shows a small white dot (as expected) but it can now only be accessed via the sector inventory box.
If anyone has read this, thanks for your patience.
Report message to a moderator
|
Corporal
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #344443 is a reply to message #344321]
|
Wed, 09 March 2016 11:03
|
|
3iff |
|
Messages:65
Registered:July 2001 Location: Birmingham, UK |
|
|
In the course of playing the game, (finishing one and 70% through the current game), I've continued to investigate the "unreachable items" problem.
For this period, I've avoided using the "getitems" activity and have manually moved items from merc to sector inventory rather that using ctrl-click...it's slow!
In this time, I've moved many hundreds of items multiple times and have not had any unreachable items.
The conclusion I get from this is that there may be some routine (or routines) that are called by "getitems" and the ctrl-click transfer that are not working on some occasions, causing unreachable items to be created. However, this doesn't happen all the time, just occasionally. Unfortunately I'm not at all familiar with the source code so I've no idea where to look and even if I did I doubt I'm knowledgeable to see any problem.
When an item is stored in sector inventory, does it have a tile or x/y co-ord saved so we know where it is? My thought is that this information is wrong for those unreachable items, placing it 'off the map' somehow so when mousing over the sector item it doesn't show a white dot showing its location. For example, if the map co-ords were 1:1 to 100:100 then any x/y that was set to 0 or >100 would be off the map.
Report message to a moderator
|
Corporal
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #344446 is a reply to message #344443]
|
Wed, 09 March 2016 13:08
|
|
Flugente |
|
Messages:3509
Registered:April 2009 Location: Germany |
|
|
The fact that while you can recreate the bug, but it always only happens on some of the moved items, not all of them (as I understand you), is very odd. I can think of one issue why an item would be unreachable, but that should then affect all items. Hmm.
For the record, if you can reliably recreate the error in some occasion - does the error also occur if you load the sector you are moving items to (where Dimitri is) in tactical before the items are moved? Or does it only happen in sectors currently not loaded?
A savegame from before the error occurs (and info on what exe and/or mods) would be appreciated.
I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.
If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.Report message to a moderator
|
|
|
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #344461 is a reply to message #344455]
|
Wed, 09 March 2016 22:10
|
|
Flugente |
|
Messages:3509
Registered:April 2009 Location: Germany |
|
|
I've altered the functions in r8100. While I hope this resolves the issue, unless I have a savegame where the error occured I am not certain, so a savegame is still very much appreciated.
I also added a check: if for some reason, we do not find a valid item dropoff point, nothing is moved (and a warning is printed out). By entering the sector one should then be able to solve this issue (this should force the mercs doing the assignment to get valid positions, which are then used to drop the items. How mercs can get invalid positions in the first place I am not sure).
I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.
If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.Report message to a moderator
|
|
|
|
|
|
|
|
|
|
Re: Aw: Re: Massive amounts of items in sectors becoming unreachable[message #344960 is a reply to message #344948]
|
Sat, 09 April 2016 19:21
|
|
Flugente |
|
Messages:3509
Registered:April 2009 Location: Germany |
|
|
Using a savegame from 3iff, I found quite a few bugs to squish in r8136:
- Fix: Get Item assignment: if no valid gridno is found, let the game find one upon loading the sector instead of risking a wrong gridno assignment
- Fix: When dropping an item in strategic inventory, height values are not set
- Fix: When looking for a valid gridno to drop items t via strategic inventory, WORLD_ITEM_REACHABLE is not reliable, as updated map topology trumps this. Instead rely upon finding a valid gridno once the sector is entered.
- Fix: when searching for a new item dropoff gridno, search for new height too
- Fix: if items are spawned mid-air, the player cannot retrieve them
Quite a few issues here. The basic crux is that when we drop an item in strategic inventory, we need to assign a location (termed gridno) to it, but if the map is unloaded, we have no idea whether a position is reachable or not. We then ca do 4 things:
- Use gMapInformation.sCenterGridNo for a location, which the game does - but is very bad, if that sector isn't the currently loaded one.
- Use the position of a merc in the sector. Good idea, but there might not be mercs here, and their positions might be invalid (tragedy occurs if you teleported a merc in strategic, as their positions aren't correctly set to invalid).
- Use the position of another item in the sector that can be reached. Sounds very good, but, as 3iff's savegame showed, does not always worl. In that savegame, a kevlar vest inside a house is set as WORLD_ITEM_REACHABLE, so we use that location for other items. But once we enter the map, that location cannot be reached (we need to break a door to physically get there), so all those items are deemed unreachable after inventory update.
- The best solution is likely this: set gridno to invalid, but also set WORLD_ITEM_GRIDNO_NOT_SET_USE_ENTRY_POINT. This causes the gridno to be set to gMapInformation.sCenterGridNo upon loading the map - at that point, we know that this is the data of the current sector.
The fourth solution is now what I use in the 'Get Items' assignment (and 3 isn't used anymore).
Additionally, there were some instances where items could be spawned in mid-air, where our mercs cannot reach them. I hope that is resolved now. In any case, they can now grab these floating items anyway.
I really hope this solves this bug for good, because I'm really running out of ideas.
I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.
If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.Report message to a moderator
|
|
|
|
|
|
|
|
Re: Aw: Re: Massive amounts of items in sectors becoming unreachable[message #345644 is a reply to message #345609]
|
Mon, 23 May 2016 10:21
|
|
3iff |
|
Messages:65
Registered:July 2001 Location: Birmingham, UK |
|
|
Sorry about the delay in continued testing but I was waiting for a new version.
A new problem has appeared. V8128 from 16th May.
Move a merc/squad/vehicle to a COMPLETELY empty sector, one with no enemy, mercs or items. DON'T go into the tactical map. Now from the strategic map with the sector inventory open, ctrl/click an item from a merc or vehicle and it becomes unreachable. If you manually move an item, it works fine - for me items appear at the top left corner...but that's fine, and they can be picked up again.
I'd appreciate it if somebody could test this to make sure it's not just me. I noticed this at the start of a new session where the sector has not yet been opened during this session, (it happened in F9 Cambria long after I'd captured it, a squad was returning after a patrol). I don't know if it might happen later in the session once the sector had been opened...only just thought about that possibility.
If this is indeed another bug I'm guessing that the sector hasn't yet been initialised so a ctrl/click transfer doesn't set something right...
However, all other ctrl/clicks in sector with stuff in them have had no instances of unreachable items so I'm thinking this bug is 95% fixed. I have yet to test 'getitem'.
Report message to a moderator
|
Corporal
|
|
|
|
|
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #355394 is a reply to message #355390]
|
Mon, 22 October 2018 12:28
|
|
townltu |
|
Messages:384
Registered:December 2017 Location: here |
|
|
bouchacha wrote on Mon, 22 October 2018 08:14...
Additionally, is there any cheat or save game editing I can do to just delete these misbehaving items? They're more irritating than anything else.
Hold [Del] and click on inaccesible item do delete it, add [shift] to delete whole stack.
Report message to a moderator
|
Master Sergeant
|
|
|
Re: Massive amounts of items in sectors becoming unreachable[message #355402 is a reply to message #355394]
|
Mon, 22 October 2018 21:31
|
|
bouchacha |
|
Messages:24
Registered:October 2013 Location: District of Columbia |
|
|
townltu wrote on Mon, 22 October 2018 09:28Hold [Del] and click on inaccesible item do delete it, add [shift] to delete whole stack.
I love you.
[Updated on: Mon, 22 October 2018 21:32] Report message to a moderator
|
Private 1st Class
|
|
|
Goto Forum:
Current Time: Fri Mar 29 08:05:39 GMT+2 2024
Total time taken to generate the page: 0.03443 seconds
|