The Bears Pit: v1.13 Bug Reports » Auto collapse inventory on turn end

Home » MODDING HQ 1.13 » v1.13 Bug Reports » Auto collapse inventory on turn end

Show: Today's Messages :: Polls :: Message Navigator

Auto collapse inventory on turn end[message #336254]

Sun, 28 September 2014 00:01

tais

Messages:656
Registered:February 2008
Location: NL

For all the people who were thinking they were going crazy since april this year, we just had someone on IRC asking why her merc inventory was going back to merc list in tactical each time she ended her turn.
For all we knew this was a bug and told her to report it but on further research it became clear that this is a "feature".

While looking further we found out that this feature is toggled in Ja2_options.ini... with the setting AUTO_COLLAPSE_INVENTORY_ON_TURN_END, it also became clear that someone decided that this should be standard behaviour...

As a first... why put something that is clearly a user preference in an ini file that is clearly too far of a reach for most players, was this because of lazy coder or what?

As a second... why set it to enabled, if YOU (the coder) like this it doesnt mean everyone does, also the fact that you put this setting in an ini makes it harder for normal players to fix this as this is not an enhancement for everyone...

As a third... @Rowa.. when this code is added to SVN and even when you port a commit from stable to the development branch please document in the revision comments.. now people who would want to "enhance" this "feature" and want to make a proper "preference" setting out of it have to go dig in the code...

As a fourth... is it so hard to see what belongs in the new game settings, preferences, ini files and xmls?
or is this just a matter of being lazy because afaik it's just a few more lines to add something to the new game settings or preferences....

As a fifth... stop putting every setting you think of in ja2_options.ini, it's already fat enough!

Report message to a moderator

First Sergeant

Re: Auto collapse inventory on turn end[message #336261]

Sun, 28 September 2014 10:51

silversurfer

Messages:2793
Registered:May 2009

Tais

As a fifth... stop putting every setting you think of in ja2_options.ini, it's already fat enough!

Hey, Ja2_Options.ini was shrunk "a lot" by removing some difficulty settings lately. Wink

Honestly, most of the time when a change to an existing feature is made the new option is set to 'off' to preserve the old behaviour.

When a new feature is added it is usually set to 'on' because people are supposed to try it out.

In the end whoever uses the development build should know that this is unstable development stuff in the works. In fact they are told that they are ~~guinea pigs~~ testers.

They couldn't wait to try out the new stuff, they should read the changes. If something is unclear they can ask in this forum and for this question they would have gotten an answer. If they are just too lazy to do that, sorry, their problem. Stick to the stable build if you don't want to run into such issues (most of the time).

About the thing that this setting should belong to user preferences. Yes, could be. Maybe it was a coder that is not familiar with interface work. I don't know. Still I don't see a reason to "go crazy" about this.

Report message to a moderator

Lieutenant

Re: Auto collapse inventory on turn end[message #336264]

Sun, 28 September 2014 11:59

tais

Messages:656
Registered:February 2008
Location: NL

Well the crazy part may be a bit overstated but still there is such a thing as expected behaviour, that's pretty much why we got this question on IRC.
Also this feature seems to have made its way into the Stable release without testing..
Because it was ported from Stable to Development and the person reporting it was also playing stable..

Report message to a moderator

First Sergeant

Previous Topic:	Crash while loading savegame
Next Topic:	Need help with some sort of freeze

Goto Forum:

-=] Back to Top [=-

Current Time: Thu Apr 18 04:42:50 GMT+3 2024

Total time taken to generate the page: 0.01265 seconds