Home » MODDING HQ 1.13 » v1.13 General Development Talk » Devin crash - Shopkeeper Script Line 990 (Shopkeeper script )
Devin crash - Shopkeeper Script Line 990[message #343077] Mon, 02 November 2015 15:02 Go to next message
edmortimer

 
Messages:1202
Registered:January 2015
Location: Home Free
OK, I've had two players report to me that in Arulco Vacations they've had a debug screen crash while attempting to buy from Devin -- both report shopkeeper script line 990, and both ran into Devin on Day 1. Now, I haven't fiddled with the shopkeeper script at all so I don't know what's causing this. I don't even know where the shopkeeper script is! (OK, I can guess I have to break into the .exe to find it) Any help would be appreciated.




Arulco Vacations Blog

Arulco Vacations Bears Pit Forum


Re: Devin crash - Shopkeeper Script Line 990[message #343079 is a reply to message #343077] Mon, 02 November 2015 18:07 Go to previous messageGo to next message
silversurfer

 
Messages:2542
Registered:May 2009
I assume you meant "ShopKeeper Interface.cpp" line 990?

Needs debugging to find the cause for the crash.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Devin crash - Shopkeeper Script Line 990[message #343080 is a reply to message #343079] Mon, 02 November 2015 18:53 Go to previous messageGo to next message
edmortimer

 
Messages:1202
Registered:January 2015
Location: Home Free
Thanks. I haven't done any debugging of JA2 as of yet so I don't know how to start or finish. Which tools to I need for the job?




Arulco Vacations Blog

Arulco Vacations Bears Pit Forum


Re: Devin crash - Shopkeeper Script Line 990[message #343081 is a reply to message #343080] Mon, 02 November 2015 19:31 Go to previous messageGo to next message
silversurfer

 
Messages:2542
Registered:May 2009
Visual Studio Express is what most of us use. You need to know how to code in C++. Otherwise you will have a hard time to figure out anything, I guess.

You will need the source code which is available here. I guess you are familiar with Tortoise SVN or other SVN clients to download the code.

Here is a guide for setting up Visual Studio to compile your own debug exe which you need to start debugging.

The debugging is the most complicated part where you need to set break points in the code to stop code execution to narrow down the point where the code crashes. The break point needs to be triggered before the crash happens for example in line 990 (break point triggers before line is executed). Then you need to check the data that leads to the crash and find out why it is not as expected and where it is set incorrectly.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Devin crash - Shopkeeper Script Line 990[message #343086 is a reply to message #343081] Tue, 03 November 2015 01:52 Go to previous messageGo to next message
edmortimer

 
Messages:1202
Registered:January 2015
Location: Home Free
Thank you for the details. I'll try -- but I'm running an old Thinkpad with Xubuntu . . . and those programs won't run on this computer. There must be others though, and I'll look.

Evidently it is an intermittent thing 'cause the other person reporting said she could buy from Devin the next time she saw him.




Arulco Vacations Blog

Arulco Vacations Bears Pit Forum


Re: Devin crash - Shopkeeper Script Line 990[message #343090 is a reply to message #343086] Tue, 03 November 2015 14:28 Go to previous messageGo to next message
silversurfer

 
Messages:2542
Registered:May 2009
edmortimer wrote on Tue, 03 November 2015 00:52

Evidently it is an intermittent thing 'cause the other person reporting said she could buy from Devin the next time she saw him.


That sounds like something wasn't initialized properly at game start and was initialized at a later time. I changed the code somewhat in r8000 to always properly initialize the temp vector when we enter the shopkeeper interface. This was done anyway some lines below so I don't see a reason not to do it a bit earlier to be safe.
If you could reproduce the bug on your system please try to reproduce it with the newer exe. I couldn't reproduce it even before the fix.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Devin crash - Shopkeeper Script Line 990[message #343091 is a reply to message #343090] Tue, 03 November 2015 15:42 Go to previous message
edmortimer

 
Messages:1202
Registered:January 2015
Location: Home Free
OK, I'll try -- right now I have to get ready for a job interview. The second reporter of the bug said he tried again, but this time let the dialogue run through completely instead of shortcutting . . . and it worked properly.




Arulco Vacations Blog

Arulco Vacations Bears Pit Forum


Previous Topic: Creating new NPC-merchant
Next Topic: Game element Questions {solved)
Goto Forum:
  


Current Time: Tue Jun 18 06:07:02 EEST 2019

Total time taken to generate the page: 0.01444 seconds