Home » MODDING HQ 1.13 » Flugente's Magika Workshop » New feature: individual militia
Re: New feature: individual militia[message #351013 is a reply to message #345324] Mon, 18 September 2017 11:11 Go to previous messageGo to next message
RunAwayScientist

 
Messages:73
Registered:September 2001


Hello Flugente,


Just to clarify: the errors and issues being encountered are with PMC and turned prisoner militia, where their profiles are being incorrectly created. Not sure if you tested with these functions, as I've yet to compile and play the latest trunk.



Re: New feature: individual militia[message #351085 is a reply to message #351013] Thu, 21 September 2017 21:40 Go to previous messageGo to next message
Flugente

 
Messages:3218
Registered:April 2009
Location: Germany
Hmm. As you've discovered, there was a mix up between soldier class and militia level. I'm not sure why, because at some point I was aware of that exact issue and used conversion functions. Weird.

Anyway, fixed in r8477. This also fixes any ranks when loading an older savegames, of course.



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


bug6.png  Re: New feature: individual militia[message #351153 is a reply to message #351085] Mon, 02 October 2017 05:29 Go to previous messageGo to next message
GiantBasher

 
Messages:32
Registered:July 2017
1. Bug Report: I trained militia in Chitzena. When viewing the Militia Overview website, it says that I have militia in Drassen (B13 & C13). I have not yet taken over Drassen, so that can't be possible. I also interrogated a prisoner and he defected to me. I disbanded him and the possible error message appeared ("POSSIBLE ERROR: NOT ENOUGH INDIVIDUAL MILITIA FOUND IN DISBANDINDIVIDUALMILITIA"). After disbanding all militia and dismissing all mercs, I confirmed that I am still paying for the militia which don't exist.

2. The saved game, screenshot, and JA 2 Options.ini, have been uploaded to drop box:
https://www.dropbox.com/sh/0a3o59qc8xhvwqs/AADxzHNfV9uWzGVF86qKLnP0a?dl=0

3. Advance time until 09:45. Read Enrico's email and open the Militia Overview Website. Sort by location and note the militia in Drassen. Close the laptop and go to the Strategic view. Enable the militia filter. Click on Chitzena and disband all militia. Note the error message. Dismiss Spike. Note the Daily Expenses remain above 0.

4. Running Windows 10, JA 2 1.13 build 8488 game directory 2391 (01 Oct 2017)
5. No Mods
Re: New feature: individual militia[message #351198 is a reply to message #351153] Thu, 05 October 2017 23:01 Go to previous messageGo to next message
Flugente

 
Messages:3218
Registered:April 2009
Location: Germany
I've fixed the appearance of that error message in r8493. But the militia profiles in Drassen already exist when one loads the savegame (it says they were trained in Drassen on Day 1, 16:00). I'm not sure where they come from though. As we completely wipe our individual militia every time we load a savegame, I don't think this could be some sort of saving/loading issue. Do you have another savegame from, like, a different campaing where these guys existed?



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


bug6.png  Re: New feature: individual militia[message #351214 is a reply to message #351198] Sat, 07 October 2017 03:05 Go to previous messageGo to next message
GiantBasher

 
Messages:32
Registered:July 2017
Flugente wrote on Thu, 05 October 2017 15:01
But the militia profiles in Drassen already exist when one loads the savegame (it says they were trained in Drassen on Day 1, 16:00). I'm not sure where they come from though. As we completely wipe our individual militia every time we load a savegame, I don't think this could be some sort of saving/loading issue. Do you have another savegame from, like, a different campaing where these guys existed?


I started a new campaign using 8488 game dir 2391. However, I saved over a previous saved game from an older campaign. I did not realize that overwriting a previous save would some how mix up the individual militia profiles. How does that work exactly?

If it helps with your analysis I have uploaded that other saved game to dropbox along with the INI (I happened to back up files prior to overwriting the save). Note that this saved game is from 8473 using game dir 2385.

https://www.dropbox.com/sh/5e03m3kksqlv8ya/AAApNJNxyNnmzRbgbmDR5Glna?dl=0
Re: New feature: individual militia[message #351473 is a reply to message #351214] Mon, 13 November 2017 21:57 Go to previous messageGo to next message
RunAwayScientist

 
Messages:73
Registered:September 2001

Dev Build - 8506


Hey Flug, bug report time:

So it appears the militia issue is almost fixed. The 'Individual Profile Duplication' bug and error message will still occur when you move a squad of militia or mobile militia into a sector that is currently loaded. It can be any sector. It happens with Kerberus or regular militia.


I have not tried reloading a bugged save to see if wiping the individual militia resolves duplicated profiles.


As long as you unload the sector from game memory by loading another sector before moving militia into it, you can avoid this bug in the current build (for now).

This is a C++ vector or variable scope issue, which is beyond my ability to fix or track down.

A very frustrating bug to figure out, for sure. Perhaps it would be better to not create a profile for a militia if it isn't found? For those with old saves, that means that only their new Kerberus or newly trained or defected militia would have profiles, but it might avoid the duplication bug. Thoughts?

[Updated on: Mon, 13 November 2017 22:00]


Re: New feature: individual militia[message #352009 is a reply to message #351473] Fri, 12 January 2018 23:59 Go to previous messageGo to next message
Shadow

 
Messages:39
Registered:December 2008
Location: Argentina
Is there any way to use the origin name generator system for regular enemies? The current profile system is rather rigid, and it'd be much better if Deidranna's goons could benefit from randomly generated, culturally-appropriate names.

The admin and army troops could follow the Arulcan standard by default, while blackshirts would have a high percentage of foreign members and therefore names (and appearance, perhaps). They are hired mercenaries, after all.

[Updated on: Fri, 12 January 2018 23:59]




Shadow's Enemy Profiles
Re: New feature: individual militia[message #352295 is a reply to message #346803] Mon, 05 February 2018 08:35 Go to previous message
Elvis_A

 
Messages:272
Registered:December 2012
Location: exUSSR
silversurfer wrote on Sat, 03 September 2016 11:14
I'd say that we should keep the names that aren't wrong (don't exist or are written incorrectly). For the sake of variety we should have as many names as we can and I don't mind if some are a short form of an other name. Most people probably don't know that anyway (including me) especially since certain names have been adopted to other countries in their short form as a regular name. If I'd call the Katja's I know "Ekaterina" they'd probably give me a strange look. ;-)

Some players probably remember the time where we still had only a handful of names for enemy/militia profiles and on every encounter we got some "Lachlan "Sir" Botticchio" or another which made me turn the feature off. So instead of removing names which aren't wrong I'd propose to correct the ones that have been written incorrectly and add your new names to increase the number of names.


Enneagon wrote on Sat, 03 September 2016 13:47
silversurfer wrote on Sat, 03 September 2016 11:14
So instead of removing names which aren't wrong I'd propose to correct the ones that have been written incorrectly and add your new names to increase the number of names.


I also don't think we should worry about obsolete names, short forms or any exact etnical conformity at all as long there no screaming typos.

Flugente wrote on Fri, 06 May 2016 17:32
PMC mercenary are russian-like. While the description I made for Kerberus potentially allows any nationality, I feel that having them immediately stand out from the locals would be good. Additionally, this lets me show off how men and women can also have different surnames.


As I understand the only goal here is to create 3 recognisably different naming lists. "Hispanic", "Russian" and "German" therefore are just very broad labels.

"Latin" and "Slavic" would probably be more appropriate labels.
Or even revert to functional labels as "local", "hired", "army" or some such.

But well, tangential discussion about labels is in itself quite... stupid (for lack of better word).

Boojum wrote on Sat, 03 September 2016 19:48
Quote:
Some players probably remember the time where we still had only a handful of names for enemy/militia profiles and on every encounter we got some "Lachlan "Sir" Botticchio" or another which made me turn the feature off.

"Sir", "tty" and so on? Yes, I remember this time too (I play 1.13 since 2011).
Quote:
Especially since certain names have been adopted to other countries in their short form as a regular name.

I didn't know how wide is it. You are right. "My name is Petya Ivanov" sounds weird to me, but if this is in use in any country, why not.
If so, how about adding more short forms for more accordance (by now, some names have their alternative forms, and some haven't, which is a bit selectively)?

Quote:
I also don't think we should worry about obsolete names, short forms or any exact etnical conformity at all as long there no screaming typos.

Oh... If no one will complain, you are right. But these old "Osip", "Lukyan" and so on sound just like Ealdgyth (en.wikipedia.org/wiki/Ealdgyth) or Aescwine.



Sorry for necroposting here, I missed the discussion.
I intentionally left old names, well because they are sometimes used. The name "Osip" actually was used in XX century. You might heard the famous russian poet Osip Mandelstam https://en.wikipedia.org/wiki/Osip_Mandelstam
I actually explained hypocorisms and as Silversurfer said I left them intentionally so non-Russian community could recognize these names.




Elvis_A wrote on Wed, 06 July 2016 21:16
most of the fore/surnames are good to use. Some of the names are not Russian however they are Slavik:
<male_forename>Borislav</male_forename>
<male_forename>Lubomir</male_forename>
etc.

Other (sur)names are non Slavik for example:
male_surname>Engelgardt</male_surname> Jewish/German

following names are the same(Hypocorisms):
<male_forename>Grigory</male_forename>
<male_forename>Grischa</male_forename>short form of Grigory (like Rob/Bob - Robert)
<male_forename>Petya</male_forename> short name for Pyotr
<male_forename>Pyotr</male_forename>
<female_forename>Maria</female_forename>
<female_forename>Masha</female_forename> short form of Maria
<female_forename>Nastja</female_forename> short form of Anastasiya
<female_forename>Natalia</female_forename>
<female_forename>Natasha</female_forename> Short form of Natalia
<female_forename>Tanya</female_forename> short form of Tatiana
<female_forename>Tatiana</female_forename>

Russia is multinational country, so it is ok to have mentioned names above since you can often see those (Georgian, Azeri, Slovenian, etc sur/names),
BUT i would remove names below:
<male_forename>Abid</male_forename> never heard
<male_forename>Abily</male_forename> same as above
<male_forename>Aburom</male_forename> //-//
<male_forename>Avda</male_forename>
<male_forename>Avim</male_forename>
<male_forename>Avit</male_forename>
<male_forename>Avksily</male_forename>
<male_forename>Darko</male_forename> i would change it to Danko, which may be used both as name and surname
<male_forename>Inal</male_forename>
<male_forename>Avtonom</male_forename>
<male_surname>Rodriguez</male_surname> I will definitely remove 3 of these
<male_surname>Rodriguez</male_surname>
<male_surname>Rodriguez</male_surname>

<female_forename>Abijah</female_forename>
<female_forename>Leda</female_forename>
<female_forename>Zenalda</female_forename> replace with Zinaida
<female_forename>Zora</female_forename>
<female_surname>Osborn</female_surname> Ozzie? ;)
<female_forename>Rachel</female_forename>


There few typos left though, if somebody interested:
<male_forename>Amrovsy</male_forename>
replace with
<male_forename>Amvrosy</male_forename>
<female_forename>Ansastasia</female_forename>
replace with
<female_forename>Anastasia</female_forename>
<male_forename>Zoinoviy</male_forename>
replace with
<male_forename>Zinoviy</male_forename>
I can add more commonly used Russian names - just let me know if they are needed.

Small Bug
If the list is empty, Sector Names and Militia names get stacked on top of each other
https://c.radikal.ru/c28/1802/80/e47bb46b4df4.jpg

[Updated on: Mon, 05 February 2018 08:46]

Previous Topic: New feature: advanced repair/dirt system
Next Topic: Pending Feature: Increased Team sizes
Goto Forum:
  


Current Time: Thu Feb 22 06:58:18 EET 2018

Total time taken to generate the page: 0.01167 seconds