Home » MODDING HQ 1.13 » v1.13 Bug Reports » Henning Van Branitz
Henning Van Branitz[message #348616] Wed, 01 February 2017 04:36 Go to next message
Damesh

 
Messages:47
Registered:January 2001
Location: Florida
I did a site search and nothing came up and I'm assuming this is a bug. I hired Henning and during the course of his activities he was losing points in his marksmanship, leadership and strength. Now this wasn't due to dehydration or hunger, but from usage, i.e. shooting, training militia and moving/running. I did noticed that when I had hired him all his training bars on each attribute were maxed out, which at the time I thought was cool as he would level those soon. Instead, they decreased and, oddly enough, after losing two points of strength that training bar went back to the start point. I ended up dismissing him at that point so I'm not sure if his strength bar would start to increase.

Has anyone else encountered that?
Re: Henning Van Branitz[message #348619 is a reply to message #348616] Wed, 01 February 2017 08:54 Go to previous messageGo to next message
Xafloz

 
Messages:76
Registered:December 2016
I guess he is one of those mercs who loose stats instead of gaining. He is just aging...
Re: Henning Van Branitz[message #348623 is a reply to message #348619] Wed, 01 February 2017 13:11 Go to previous messageGo to next message
silversurfer

 
Messages:2207
Registered:May 2009
Evolution is defined in MercProfiles.xml and <bEvolution> can have the following values:

NORMAL_EVOLUTION = 0
NO_EVOLUTION = 1
DEVOLVE = 2
THREEQUARTER_EVOLUTION = 3
HALF_EVOLUTION = 4
ONEQUARTER_EVOLUTION = 5

In default 1.13 this value is set to 1 for Henning so he cannot increase his stats but he also shouldn't lose points.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Henning Van Branitz[message #348633 is a reply to message #348623] Wed, 01 February 2017 20:34 Go to previous messageGo to next message
Flugente

 
Messages:3165
Registered:April 2009
Location: Germany
While this behavior (mercs losing their stats, or not progressing at all) is vanilla behavior, I'm wondering... why exactly do we keep it? I mean, this is a mechanic that makes no sense (we get worse in stats by training them? wut?) and absolutely sucks ingame, as changing this requires a new game (or changing it via debugger).

Yes, vanilla code is holy etc., but would there actually be any harm in removing this (not making this as option, we have way too many of those)? After all, nobody ever complains that the IMP quiz is gone...



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


Re: Henning Van Branitz[message #348635 is a reply to message #348633] Wed, 01 February 2017 21:39 Go to previous messageGo to next message
Gorro der Grüne

 
Messages:1570
Registered:March 2009
Location: Broadwurschd-City
actually there are players (like me) who love it,

and don't You need it for Larry?

[Updated on: Wed, 01 February 2017 21:40]




I don't like users who edit posts after they've gotten an answer.

A lot of people start panicing when told to use their brains

Commander in Croc, OFBA

Founder and Leader of the GDTS
Re: Henning Van Branitz[message #348636 is a reply to message #348635] Wed, 01 February 2017 21:43 Go to previous messageGo to next message
Flugente

 
Messages:3165
Registered:April 2009
Location: Germany
This is not related to Larry.



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


icon3.gif  Re: Henning Van Branitz[message #348638 is a reply to message #348636] Wed, 01 February 2017 21:50 Go to previous messageGo to next message
Gorro der Grüne

 
Messages:1570
Registered:March 2009
Location: Broadwurschd-City
but to drugged Larry I think



I don't like users who edit posts after they've gotten an answer.

A lot of people start panicing when told to use their brains

Commander in Croc, OFBA

Founder and Leader of the GDTS
Re: Henning Van Branitz[message #348641 is a reply to message #348633] Wed, 01 February 2017 22:13 Go to previous messageGo to next message
edmortimer

 
Messages:859
Registered:January 2015
Location: Home Free
Quote:
Yes, vanilla code is holy etc., but would there actually be any harm in removing this (not making this as option, we have way too many of those)? After all, nobody ever complains that the IMP quiz is gone...


All you have to do is tweak their MercProfiles.xml entry -- change the Evolution tag (which you know already). The Evolution tag is useful for varying the progress of stat and level gain for the older or 'intellectually impaired' Mercs. Both AV & VR have modified the Evolution tag to be used by more Mercs, and to eliminate any Merc losing stats. Mercs like Pops and Moses progress slowly, other Mercs like Henning & Len progress slow but not as slow as Pops & Moses, etc.




Arulco Vacations Blog

Arulco Vacations Bears Pit Forum


Re: Henning Van Branitz[message #348644 is a reply to message #348633] Wed, 01 February 2017 23:37 Go to previous messageGo to next message
silversurfer

 
Messages:2207
Registered:May 2009
Flugente wrote on Wed, 01 February 2017 19:34
While this behavior (mercs losing their stats, or not progressing at all) is vanilla behavior, I'm wondering... why exactly do we keep it? I mean, this is a mechanic that makes no sense (we get worse in stats by training them? wut?) and absolutely sucks ingame, as changing this requires a new game (or changing it via debugger).

From what I have seen mercs with the "devolve" stat do not lose points for training but they will lose points over time.
Anyway I agree that this sucks because our little war doesn't last several years where the merc just sits around which could explain him getting older and losing some abilities.

However, it's only Larry (drunk) and Moses that have "devolve" set so I don't consider it a big problem. If a merc with NO_EVOLUTION loses points for no reason then this is a bug.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Henning Van Branitz[message #348647 is a reply to message #348644] Thu, 02 February 2017 00:03 Go to previous messageGo to next message
Damesh

 
Messages:47
Registered:January 2001
Location: Florida
I looked in the mercprofiles.xlm and it shows him as 2 for evolution. So, he's supposed to devolve statwise. Bummer, I had never used him and was looking forward to trying him out...heavy weapons, teacher with high leadership and marksmanship seemed like a good combo.
Re: Henning Van Branitz[message #348649 is a reply to message #348647] Thu, 02 February 2017 01:13 Go to previous messageGo to next message
silversurfer

 
Messages:2207
Registered:May 2009
Which mod are you using? Default 1.13 has him set to 1.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Henning Van Branitz[message #348650 is a reply to message #348649] Thu, 02 February 2017 01:19 Go to previous messageGo to next message
Damesh

 
Messages:47
Registered:January 2001
Location: Florida
Version 1.13.7609 and it says release 14.10.24
Re: Henning Van Branitz[message #348651 is a reply to message #348650] Thu, 02 February 2017 02:57 Go to previous messageGo to next message
Flugente

 
Messages:3165
Registered:April 2009
Location: Germany
I am fully aware that once can simply set this behavior off in MercProfiles.xml. But no new player is going to check that meaning, so at some point they will discover this and learn that the merc they hired is very useless without the game giving them any indication of this, and there being no fix apart from starting a new campaign.



Saren threw his head back and screamed in impotent fury, before falling to his throne, head in his claws, trembling in horrified disbelief.

Then he heard a faint chime as Sovereign subscribed to her ECHO channel.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


Re: Henning Van Branitz[message #348655 is a reply to message #348651] Thu, 02 February 2017 08:21 Go to previous messageGo to next message
edmortimer

 
Messages:859
Registered:January 2015
Location: Home Free
Quote:
I am fully aware that once can simply set this behavior off in MercProfiles.xml. But no new player is going to check that meaning, so at some point they will discover this and learn that the merc they hired is very useless without the game giving them any indication of this, and there being no fix apart from starting a new campaign.


True, true. I didn't mean that -- I meant why not just change the official, up-to-date, latest-release, v1.13 MercProfiles.xml so no Merc devolves?

EDIT: It doesn't matter to AV or VR if the code is changed or not, as both are based on 7609. I'm just thinking 'wouldn't it be easier to just change 2 numbers in an xml file'?

[Updated on: Thu, 02 February 2017 08:24]





Arulco Vacations Blog

Arulco Vacations Bears Pit Forum


Re: Henning Van Branitz[message #348656 is a reply to message #348655] Thu, 02 February 2017 09:09 Go to previous messageGo to next message
Xafloz

 
Messages:76
Registered:December 2016
Quote:
I'm just thinking 'wouldn't it be easier to just change 2 numbers in an xml file'?


The simplest and the most effective approch imho.
Re: Henning Van Branitz[message #348660 is a reply to message #348650] Thu, 02 February 2017 10:54 Go to previous messageGo to next message
silversurfer

 
Messages:2207
Registered:May 2009
Damesh wrote on Thu, 02 February 2017 00:19
Version 1.13.7609 and it says release 14.10.24

This is the old stable version and even there Henning is set to 1 on the SVN server. Strange...
Anyway, if you don't plan to use mods that are based on version 7609 you might as well try the current development build. A single click installer for that can be found here.

edmortimer wrote on Thu, 02 February 2017 07:21
I'm just thinking 'wouldn't it be easier to just change 2 numbers in an xml file'?

Actually no. If at all only Moses should be adjusted. Drunken Larry should stay as it is because the decline of his stats is a feature not a bug.



Wildfire Maps Mod 6.07 on SVN: https://ja2svn.mooo.com/source/ja2/branches/Wanne/JA2%201.13%20Wildfire%206.06%20-%20Maps%20MOD

Re: Henning Van Branitz[message #348661 is a reply to message #348635] Thu, 02 February 2017 11:03 Go to previous message
Hawkeye

 
Messages:1680
Registered:October 2005
Location: Australia
Gorro der Grüne wrote on Thu, 02 February 2017 06:39
actually there are players (like me) who love it,



Me too, in life there's some people you just can't help. I think it adds more diversity in the character pool, and not every merc is a bushy-tailed pillar of learning.


Previous Topic: Reproducible deadlock in SCI unstable 8366 (2017-01-15 build)
Next Topic: Laptop does not connect/load anything
Goto Forum:
  


Current Time: Tue Dec 12 21:39:58 EET 2017

Total time taken to generate the page: 0.01811 seconds