Home » MODDING HQ 1.13 » v1.13 Bug Reports » Improve Prejudice IMP Screen ( with patch )
|
|
| Re: Improve Prejudice IMP Screen ( with patch )[message #350555 is a reply to message #350554]
|
Fri, 11 August 2017 23:38  
|
|
| Flugente |
 |
Messages:3509
Registered:April 2009
Location: Germany |
|
|
Hi oak43, welcome to the pit!
While I would like to commit your change, there are a few problems with it:
- Inside an enum declaration you cannot introduce use the same symbol (PERSONALITYTEXT_UNUSED) twice. Did this compile successfully?
- It doesn't make much sense to define a text that we know won't be used anyway. If a line can be deleted, just delete it from the array and the enum, no need for placeholders.
[Updated on: Fri, 11 August 2017 23:40]
I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.
If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.Report message to a moderator
|
|
|
|
|
| Re: Improve Prejudice IMP Screen ( with patch )[message #350563 is a reply to message #350555]
|
Sat, 12 August 2017 08:12
|
|
 oak43 |
 |
Messages:11
Registered:August 2017 |
|
|
Flugente wrote on Fri, 11 August 2017 23:38Hi oak43, welcome to the pit!
While I would like to commit your change, there are a few problems with it:
sure, i appreciate your review!
Quote:
[*] Inside an enum declaration you cannot introduce use the same symbol (PERSONALITYTEXT_UNUSED) twice. Did this compile successfully?
Well, it did not. i'll remove then.
Quote:
[*] It doesn't make much sense to define a text that we know won't be used anyway. If a line can be deleted, just delete it from the array and the enum, no need for placeholders.[/list]
Alright, i'll give it a try, and report back.
thanks for your help!
Report message to a moderator
|
Private
|
|
|
|
| Re: Improve Prejudice IMP Screen ( with patch )[message #350568 is a reply to message #350563]
|
Sat, 12 August 2017 19:05
|
|
| oak43 |
|
Messages:11
Registered:August 2017 |
|
|
Hi again,
and my saturday is gone 
patch 1: prejudice : https ://pastebin.com/zuHXj8We
patch 2: <memory> : https ://pastebin.com/xRHNcxNm
patch 3: hash_map : https ://pastebin.com/2cziwewK
I've applied your suggestions and it compiles just fine.
1) I had to add #include <memory> to MPConnectScreen.cpp to be able to compile even before i changed the code. its in a single patch.
Also, added:
#define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS
in vobject.cpp due to hash_map being deprecated, I left it in a separated patch
2) the rest of the changes I've described yesterday.
so right now the creation screen looks like this:
http ://imgur.com/rED9XUS
3) Nationality
You can either choose to
a ) hate a nationality <somewhat>, <extremely>
http ://imgur.com/gByl6Pq
b ) hate no one
http ://imgur.com/SD7A9vj
c ) hate nationality <not>
( i've left this one, but it seems redundant )
http ://imgur.com/k48Sr3z
Which means:
http ://imgur.com/L0YorxP
4) Race and Sex
I've introduced a new "race", HUMAN, and changed the merc info, imp creation screen and merc_compare website.
I wanted to discuss this before i change more code.
It makes no sense to be not racist and then having to choose a "race".
So, it also means you can choose to be racist and human, but you will have no hate, and just be discriminated like any other choice.
I also changed the appearance of the merc comparison:
a ) is sexist but likes very attractive person of the opposite sex.
b ) is racist
http ://imgur.com/59yFYzk
If you like it, the next step if to add a check on the morale logic to check if is human racist, otherwise, the logic is perfect.
if ( pProfileA->bRacist && pProfileA->bRace != HUMAN_R )
Let me know if you have more suggestions!
p.
Report message to a moderator
|
Private
|
|
|
|
|
|
Goto Forum:
Current Time: Thu Apr 18 05:51:49 GMT+3 2024
Total time taken to generate the page: 0.01033 seconds
|
Blog
Search
Help
Members
Register
Login
Home
