Home » MODDING HQ 1.13 » v1.13 Bug Reports » Improve Prejudice IMP Screen ( with patch )
Improve Prejudice IMP Screen ( with patch )[message #350554] Fri, 11 August 2017 22:40 Go to next message
oak43

 
Messages:13
Registered:August 2017
Hi!

I hope this is the place to add pull request to the repo.

I've simplified the IMP Screen to match this wireframe:

http://i.imgur.com/FbObstP.png


also,
- Fixed some typos ( nationalities )
- Changed the help hints for the dropdown choices.

I don't know c++ code standards, so not sure what to with the enum that has unused values ( renamed them to PERSONALITYTEXT_UNUSED ) to keep the indexes on the text. angel

I also didn't change the other languages texts, until this is approved.

Patch:

( remove the space after the protocol )
https://pastebin.com/7SgkEfs8

thanks, let me know if i made a mistake or want something different.

[Updated on: Sat, 12 August 2017 12:23] by Moderator

Re: Improve Prejudice IMP Screen ( with patch )[message #350555 is a reply to message #350554] Fri, 11 August 2017 23:38 Go to previous messageGo to next message
Flugente

 
Messages:3339
Registered:April 2009
Location: Germany
Hi oak43, welcome to the pit!

While I would like to commit your change, there are a few problems with it:

  • Inside an enum declaration you cannot introduce use the same symbol (PERSONALITYTEXT_UNUSED) twice. Did this compile successfully?
  • It doesn't make much sense to define a text that we know won't be used anyway. If a line can be deleted, just delete it from the array and the enum, no need for placeholders.

[Updated on: Fri, 11 August 2017 23:40]




“What are you doing?” Joffrey interrupted him.

“… can’t a man give a few last words for his son to carry?”

“…Who told you your son was making it out of this field alive?”

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.


Re: Improve Prejudice IMP Screen ( with patch )[message #350563 is a reply to message #350555] Sat, 12 August 2017 08:12 Go to previous messageGo to next message
oak43

 
Messages:13
Registered:August 2017
Flugente wrote on Fri, 11 August 2017 23:38
Hi oak43, welcome to the pit!

While I would like to commit your change, there are a few problems with it:


sure, i appreciate your review!


Quote:

[*] Inside an enum declaration you cannot introduce use the same symbol (PERSONALITYTEXT_UNUSED) twice. Did this compile successfully?


Well, it did not. i'll remove then.

Quote:

[*] It doesn't make much sense to define a text that we know won't be used anyway. If a line can be deleted, just delete it from the array and the enum, no need for placeholders.[/list]


Alright, i'll give it a try, and report back.

thanks for your help!
Re: Improve Prejudice IMP Screen ( with patch )[message #350568 is a reply to message #350563] Sat, 12 August 2017 19:05 Go to previous messageGo to next message
oak43

 
Messages:13
Registered:August 2017
Hi again,

and my saturday is gone big grin

patch 1: prejudice : https ://pastebin.com/zuHXj8We
patch 2: <memory> : https ://pastebin.com/xRHNcxNm
patch 3: hash_map : https ://pastebin.com/2cziwewK


I've applied your suggestions and it compiles just fine.

1) I had to add #include <memory> to MPConnectScreen.cpp to be able to compile even before i changed the code. its in a single patch.

Also, added:

#define _SILENCE_STDEXT_HASH_DEPRECATION_WARNINGS

in vobject.cpp due to hash_map being deprecated, I left it in a separated patch



2) the rest of the changes I've described yesterday.

so right now the creation screen looks like this:

http ://imgur.com/rED9XUS


3) Nationality

You can either choose to
a ) hate a nationality <somewhat>, <extremely>

http ://imgur.com/gByl6Pq

b ) hate no one

http ://imgur.com/SD7A9vj

c ) hate nationality <not>
( i've left this one, but it seems redundant )

http ://imgur.com/k48Sr3z


Which means:

http ://imgur.com/L0YorxP


4) Race and Sex

I've introduced a new "race", HUMAN, and changed the merc info, imp creation screen and merc_compare website.
I wanted to discuss this before i change more code.
It makes no sense to be not racist and then having to choose a "race".
So, it also means you can choose to be racist and human, but you will have no hate, and just be discriminated like any other choice.

I also changed the appearance of the merc comparison:

a ) is sexist but likes very attractive person of the opposite sex.
b ) is racist


http ://imgur.com/59yFYzk

If you like it, the next step if to add a check on the morale logic to check if is human racist, otherwise, the logic is perfect.

if ( pProfileA->bRacist && pProfileA->bRace != HUMAN_R )


Let me know if you have more suggestions!

p.
Re: Improve Prejudice IMP Screen ( with patch )[message #350569 is a reply to message #350568] Sat, 12 August 2017 19:05 Go to previous message
oak43

 
Messages:13
Registered:August 2017
ps: i still can't add links, sorry for the hack
Previous Topic: v1.13 multiplayer save game problems
Next Topic: r8452 - Shop Graphic - Almost stops game
Goto Forum:
  


Current Time: Mon Jun 25 07:17:37 EEST 2018

Total time taken to generate the page: 0.00742 seconds