Home » SIRTECH CLASSICS » Jagged Alliance: Unfinished Business » Vanilla Modding » A few embarrassing source code bugs...
A few embarrassing source code bugs...[message #101680] Tue, 10 August 2004 19:09 Go to next message
Chris Camfield is currently offline Chris Camfield

 
Messages:68
Registered:February 2000
Location: Toronto, Ontario
Maybe you guys have already found and fixed these. I was pretty horrified to discover them.

This was using defrog's C++ version of the code.

LibraryDatabase.cpp, line 319 - an "if" statement leading only to a debug message. With the debug message #define'd out (in Release mode), that leads to the if statement modifying the FOLLOWING line of code... which it shouldn't do. Put {} in.

There were a couple of these debug msg warnings... real problems, potentially.


FindLocations.cpp, line 519 - an "if" statement with a semicolon at the end! Delete it! This routine is used to reduce the value of cover locations which are next to friendly teammates, for the AI. The semicolon screws up the logic.

AIUtils.cpp, line 947 - DITTO! This is in a routine which gets the AI to determine the closest known noise etc. I don't know where the hell these came from!

Soldier Profile.cpp, line 280 - yet another semicolon, this in code which is supposed to replace ammo of one sort with another for games played without "Tons of Guns".

I think that's it... Surprised

Report message to a moderator

Corporal
Re: A few embarrassing source code bugs...[message #101681] Fri, 03 September 2004 01:28 Go to previous message
defrog is currently offline defrog

 
Messages:235
Registered:March 2004
Location: Austria
I was wondering about those!
I also ran into some where there was an if statement with just a ; on the line below....
(unfortunately it doesn't look like I marked them with my jonathanl tag, sorry)

there was a lot of crazy code...
you had functions being called incorrectly
like in AimMembers.cpp ln 3704 (regular C lets you get away with murder!)

Report message to a moderator

Sergeant 1st Class
Previous Topic: Request, LOS/LOF bug
Next Topic: C++ version testing
Goto Forum:
  


Current Time: Sun Feb 09 18:10:57 GMT+2 2025

Total time taken to generate the page: 0.00812 seconds