The Bears Pit: Stracciatella Project (Platform Independent JA2) » Crash when going into tactical screen on mine sectors

Home » PLAYER'S HQ 1.13 » JA2 Complete Mods & Sequels » Stracciatella Project (Platform Independent JA2) » Crash when going into tactical screen on mine sectors

Show: Today's Messages :: Polls :: Message Navigator

Re: Crash when going into tactical screen on mine sectors[message #250719]

Fri, 30 April 2010 10:34

mgl

Messages:255
Registered:December 2007
Location: France

I haven't looked at this problem yet, but ...

From What I know, the NODEs are structures, objects, things like floor, roofs, boulders... lying on the tiles (gridnos) of the map. They shouldn't try to scan gridnos greater than WORLD_MAX.

I looked at its value last week for the GridNo bug and I think it's 25600.

I think it would be better if the caller does the "gridno < WORLD_MAX" test itself and calls the function "FloorAtGridNo()" only if the GridNo is valid. The spirit of your current fix is that the function "FloorAtGridNo()" answers that there's no floor on this invalid GridNo (map_idx), not that the GridNo is invalid. And it's not its job to tell that the gridno is invalid. The GridNo should have been acknowledged as invalid earlier in the caller's code and the caller shouldn't try to do anything with it.

Report message to a moderator

Master Sergeant

[Message index]

		Crash when going into tactical screen on mine sectors By: bbun on Wed, 31 March 2010 11:33
		Re: Crash when going into tactical screen on mine sectors By: bbun on Wed, 21 April 2010 23:34
		Re: Crash when going into tactical screen on mine sectors By: mgl on Thu, 22 April 2010 00:00
		Re: Crash when going into tactical screen on mine sectors By: bbun on Thu, 22 April 2010 21:57
		Re: Crash when going into tactical screen on mine sectors By: mgl on Thu, 22 April 2010 23:57
		Re: Crash when going into tactical screen on mine sectors By: usrbid on Fri, 23 April 2010 07:18
		Re: Crash when going into tactical screen on mine sectors By: bbun on Fri, 23 April 2010 14:15
		Re: Crash when going into tactical screen on mine sectors By: SpaceViking on Fri, 23 April 2010 18:55
		Re: Crash when going into tactical screen on mine sectors By: mgl on Sat, 24 April 2010 12:03
		Re: Crash when going into tactical screen on mine sectors By: bbun on Sun, 25 April 2010 16:39
		Re: Crash when going into tactical screen on mine sectors By: bbun on Wed, 28 April 2010 22:48
		Re: Crash when going into tactical screen on mine sectors By: bbun on Fri, 30 April 2010 01:22
		Re: Crash when going into tactical screen on mine sectors By: mgl on Fri, 30 April 2010 10:34
		Re: Crash when going into tactical screen on mine sectors By: mgl on Fri, 30 April 2010 12:28
		Re: Crash when going into tactical screen on mine sectors By: bbun on Fri, 30 April 2010 14:20
		Re: Crash when going into tactical screen on mine sectors By: mgl on Fri, 30 April 2010 19:31
		Re: Crash when going into tactical screen on mine sectors By: bbun on Fri, 30 April 2010 20:13
		Re: Crash when going into tactical screen on mine sectors By: Tron on Tue, 04 May 2010 10:47
		Re: Crash when going into tactical screen on mine sectors By: bbun on Tue, 04 May 2010 13:28
		Re: Crash when going into tactical screen on mine sectors By: mgl on Wed, 05 May 2010 00:08
		Re: Crash when going into tactical screen on mine sectors By: Helios on Wed, 05 May 2010 13:49

Previous Topic:	Bus Error @ Tactical screen
Next Topic:	Bug: looking for enemies in adjacent sectors

Goto Forum:

-=] Back to Top [=-

Current Time: Sat Jan 11 01:49:46 GMT+2 2025

Total time taken to generate the page: 0.01035 seconds