Home » MODDING HQ 1.13 » v1.13 Bug Reports » Merchant interface crash on 2560x1440 (works with res 1920x1080)
Merchant interface crash on 2560x1440[message #360371] Mon, 15 June 2020 08:16 Go to next message
Jamo is currently offline Jamo

 
Messages:14
Registered:July 2006
Location: Finland, land of ice bear...
 Game crashes on merchant interface when player selects an item to sell on resolution 2560x1440.

If I change resolution to 1920x1080, sales seem to work normally. This is easy to test with Tony.

I have "extra merchants" turned on. Revision 8796, gamedir 2531, installed on clean JA2. No mods.

Report message to a moderator
Private
Re: Merchant interface crash on 2560x1440[message #360387 is a reply to message #360371] Tue, 16 June 2020 21:58 Go to previous messageGo to next message
Flugente

 
Messages:3509
Registered:April 2009
Location: Germany
 Can't really test that because I don't have a giant monitor, but at least buying things from a shopkeeper works fine. Hmm. Is there any way you can recreate this in a way that doesn't require me to see the merc's inventory?

I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.

Report message to a moderator
Captain
Re: Merchant interface crash on 2560x1440[message #360389 is a reply to message #360387] Wed, 17 June 2020 02:22 Go to previous messageGo to next message
Jamo is currently offline Jamo

 
Messages:14
Registered:July 2006
Location: Finland, land of ice bear...
 Looks like same thing happens on windowed mode. It's not related directly to WxH but most likely how resources are reserved.

Did some testing and here are some numbers for you:


    2476x1500 crash
    2475x1500 works
    3511x1200 works
    3512x1200 crash
For quick testing you can use any merchant, including one in Omerta rebel basement.

Report message to a moderator
Private
Re: Merchant interface crash on 2560x1440[message #360390 is a reply to message #360389] Wed, 17 June 2020 03:58 Go to previous messageGo to next message
Jamo is currently offline Jamo

 
Messages:14
Registered:July 2006
Location: Finland, land of ice bear...
 Yeah, I was thinking more of this. Certain magic number comes to the mind. Let's take a guess.

Here are grid places for items on merchant, transaction and selling areas.

2476x1500 crash, merch grid 18x15=270, transact 19x2=38, sales grid 19x14=266
2475x1500 works, merch grid 17x15=255, transact 18x2=36, sales grid 18x14=252
3511x1200 works, merch grid 24x11=264, transact 25x2=50, sales grid 25x10=250
3512x1200 crash, merch grid 25x11=275, transact 26x2=52, sales grid 26x10=260

windowed mode, 2560x1440 works:
merch grid 18x14=252, transact 19x2=38, sales grid 19x13=247

fullscreen mode crashes, 2560x1440:
merch grid 18x15=270, transact 19x2=38, sales grid 19x14=266

works:
4000x1000, merch grid 28x8=224, transact 29x2=58, sales grid 29x7=203

works:
5000X1000, having hard time to get merch inventory in full view, JA2 does not like virtual desktops and you can't move game partially outside of desktop area

works:
4000x1100, merch grid 28x9=252, transact 29x2=58, sales grid 29x9=232

4500x1100 crashes, merch grid 31x9=279, transact 32x2=64, sales grid 32x8=256
buying works but we have some other interface problems here

So, what's your number? My number starts with f and ends with f.

Spoiler: 0xff=255

Report message to a moderator
Private
Re: Merchant interface crash on 2560x1440[message #360399 is a reply to message #360390] Thu, 18 June 2020 00:50 Go to previous messageGo to next message
Flugente

 
Messages:3509
Registered:April 2009
Location: Germany
 Well, the good news is that I identified the error. Though from the looks of it, the magic number could as well have been 127 or 500. Shopkeeper code is... not the best.

The bad news is that I've found a bug way, waaay worse when one plays with a resolution higher than what one's monitor can handle. So... it might be a while.

I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.

Report message to a moderator
Captain
Re: Merchant interface crash on 2560x1440[message #360401 is a reply to message #360399] Thu, 18 June 2020 01:26 Go to previous messageGo to next message
Flugente

 
Messages:3509
Registered:April 2009
Location: Germany
 But not that long, it seems. Should be fixed in r8823, let me know if it isn't.

I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.

Report message to a moderator
Captain
Re: Merchant interface crash on 2560x1440[message #360426 is a reply to message #360401] Mon, 22 June 2020 20:08 Go to previous messageGo to next message
Jamo is currently offline Jamo

 
Messages:14
Registered:July 2006
Location: Finland, land of ice bear...
 Nice! Thank you very much!

I would like to test the changes but latest on MS Onedrive is still 8796. Dumb question but are new not-yet released versions stored somewhere?

... well, I found SVN-repo but looks like I need to install Windows C-compiler for that. Though I have survived the horrors of Javascript so anything goes...

I can wait for new SCI release if there are no hurry to test things or if there aren't new SCI release coming in near future I could use my dedicated NO-WORK gaming machine to something useful.

Report message to a moderator
Private
Re: Merchant interface crash on 2560x1440[message #360427 is a reply to message #360426] Mon, 22 June 2020 20:30 Go to previous messageGo to next message
Deleted.

 
Messages:2663
Registered:December 2012
Location: Russian Federation
 You can find latest trunk exe on my google drive, but you will also need actual gamedir from svn.

Left this community.

Report message to a moderator
Lieutenant
Re: Merchant interface crash on 2560x1440[message #360428 is a reply to message #360426] Mon, 22 June 2020 20:36 Go to previous messageGo to next message
Asdow is currently offline Asdow

 
Messages:126
Registered:August 2010
I def recommend compiling it from the source if you have any interest in testing or improving JA. The actual compiling is very easy to set up and working on the source code is an... interesting experience.

Report message to a moderator
Sergeant
Re: Merchant interface crash on 2560x1440[message #360429 is a reply to message #360426] Tue, 23 June 2020 00:07 Go to previous messageGo to next message
Flugente

 
Messages:3509
Registered:April 2009
Location: Germany
 Jamo wrote on Mon, 22 June 2020 17:08
Nice! Thank you very much!

I would like to test the changes but latest on MS Onedrive is still 8796. Dumb question but are new not-yet released versions stored somewhere?

... well, I found SVN-repo but looks like I need to install Windows C-compiler for that. Though I have survived the horrors of Javascript so anything goes...

I can wait for new SCI release if there are no hurry to test things or if there aren't new SCI release coming in near future I could use my dedicated NO-WORK gaming machine to something useful.
Well, you're the only one to report this bug, so this isn't in a particular hurry. No need to worry on that end.

I know now that it could never work between us, as much as we wanted to, it could never be! Not because you're a rabbit, but because you're black.

If you want, you can donate to me. This will not affect how and what I code, and I will not code specific features in return. I will be thankful though.

Report message to a moderator
Captain
Re: Merchant interface crash on 2560x1440[message #360444 is a reply to message #360429] Wed, 24 June 2020 21:43 Go to previous message
Jamo is currently offline Jamo

 
Messages:14
Registered:July 2006
Location: Finland, land of ice bear...
 Yep, works as intended in r8823 & gamedir 2552. Windowed mode 4500x1100 works too!

About compiling, I guess I could try. There seems to be a lot of forum messages about getting VS to working order so... why not.

Report message to a moderator
Private
Previous Topic: Alternative Map Error
Next Topic: Turning back moving militia could spawn them at middle of the enemies
Goto Forum:
  


Current Time: Thu Apr 18 04:37:57 GMT+3 2024

Total time taken to generate the page: 0.01076 seconds
.:: Contact :: Home ::.

Powered by: FUDforum 3.1.3.
Copyright ©2001-2023 FUDforum Bulletin Board Software