BP Logo
Home » MODDING HQ 1.13 » v1.13 Bug Reports » Bugs: Unofficial releases (SCI's), unstable and DEV builds (Read the first post before posting!)
Re: Bugs: Unofficial releases (SCI's), unstable and DEV builds[message #363468 is a reply to message #363466] Mon, 05 July 2021 20:35 Go to previous messageGo to next message
CarsonBlackman

 
Messages:61
Registered:August 2019
Location: At the beach
Just a thought.
Sometimes even when Tony is there, Hans won't let you in. I seem to remember that Hans doesn't always respond well to the "friendly" approach. Try speaking to him as "direct" instead.
If everything else fails, a little C4 in just the right spot...
Re: Bugs: Unofficial releases (SCI's), unstable and DEV builds[message #363469 is a reply to message #363466] Mon, 05 July 2021 21:06 Go to previous messageGo to next message
edmortimer

 
Messages:1496
Registered:January 2015
Location: Home Free
Quote:
JA2-Unstable-r9123-g2595 and ja2_1.13_beta_eng_gr9112_dr2594
CHANCE_TONY_AVAILABLE = 100
but Hans still says "Tony stepped out for a bit"
Check the room number Tony is in (with the map editor), and then check the room number the game thinks he should be in - in Mod_Settings.ini (PORN_SHOP_ROOM_TONY =).

[Updated on: Mon, 05 July 2021 21:12]


Re: Bugs: Unofficial releases (SCI's), unstable and DEV builds[message #363472 is a reply to message #363466] Mon, 05 July 2021 23:23 Go to previous messageGo to next message
Kitty

 
Messages:321
Registered:October 2017
Location: Germany
rasz wrote on Mon, 05 July 2021 16:30
JA2-Unstable-r9123-g2595 and ja2_1.13_beta_eng_gr9112_dr2594
CHANCE_TONY_AVAILABLE = 100
but Hans still says "Tony stepped out for a bit"

I feel like Im taking crazy pills. I went as far back as SCI_Unstable_Revision_8345_on_GameDir_2349 from 2016 and I cant get Hans to let me to the back room angry
New game, leadership 75, rush to San Mona, give Brenda VHS tape, Hans keeps telling me Tony is not here, or about his inventory. Killing Hans reveals Tony is in the back room.
I even somehow managed to land in front of the door with Hans to the right (no idea how) and Hans STILL insist Tony is not here while Tony is visible on the screen.

https://i.imgur.com/u68MeZV.jpg
Reported your issue on Discord, here is what I got:

"Flugente -- 03.07.2021

I assume the variable was already set to 100 when Tony didn't show up, because the chance of whether he appears is determined every morning, so variable changes are not instant

in any case, it's used in Scripts/StrategicEventHandler.lua in HandleEarlyMorningEvents()

Tony's existence is also not rerolled if the sector is currently loaded"


To try, if that might be the cause, you could leave the sector and come back the next day (after 07:00)



How to get: latest 1.13, 7609 and more | 7609 SCI (eng) | Compiling+SVN

I need more details. (Didi Hallervorden)
Re: Bugs: Unofficial releases (SCI's), unstable and DEV builds[message #363473 is a reply to message #363472] Tue, 06 July 2021 15:40 Go to previous messageGo to next message
rasz

 
Messages:38
Registered:August 2006
I briefly looked at the (older) source code yesterday

		if (Random( 99 ) < gGameExternalOptions.ubChanceTonyAvailable) // silversurfer/SANDRO
		{
			// Tony IS available
			SetFactFalse( FACT_TONY_NOT_AVAILABLE );
			gMercProfiles[ TONY ].sSectorX = 5;
			gMercProfiles[ TONY ].sSectorY = MAP_ROW_C;
		}

and already tried sitting few days in C6, didnt fix it angry
I used cheats (CTRL-G) to teleport myself into backroom (ALT+Q, ALT-T), and even when Tony is at the spot in front of his desk Hans wont let me in. I even spawned few other random mercs with high leadership just to be sure, always same inventory talk.
F11 Debug menu:

FACT_BRENDA_IN_STORE_AND_ALIVE 78 false
FACT_BRENDA_DEAD 79 false
FACT_CONVO_BRENDA_1 true

Brenda taken care of

FACT_CONVO_HANS 84 false
FACT_HANS_AT_SPOT 85 false
FACT_TONY_NOT_AVAILABLE false

>grep -r FACT_CONVO_HANS ja2-1.13-source-mirror-master
>ja2-1.13-source-mirror-master/Strategic/Quests.h: FACT_CONVO_HANS,

FACT_CONVO_HANS is never set, and never used? (This is old codebase)
Edit: nvm, bad coding practices strike again

case FACT_84_AND_85_TRUE:
			gubFact[usFact] = CheckFact( 84, ubProfileID ) && CheckFact( FACT_HANS_AT_SPOT, ubProfileID );
			break;
someone used literals so now its hard to find it angry EDIT: in original JA2 this was non descriptively declared as
"FACT_84 = 84, // XXX TODO0018" with FactDescText "Hans lets you see Tony", 1.13 renamed it to FACT_CONVO_HANS with broken FactDescText "Hans lets ou see Tony". Person doing this change must of slipped in this one spot and changed FACT_84 to 84 instead of FACT_CONVO_HANS.

[Updated on: Thu, 08 July 2021 18:40]

Re: Bugs: Unofficial releases (SCI's), unstable and DEV builds[message #363485 is a reply to message #363472] Thu, 08 July 2021 18:21 Go to previous message
rasz

 
Messages:38
Registered:August 2006
Merely setting FACT_CONVO_HANS to True in F11 quest debug menu fixes this, all of a sudden Hans says "I bet you are to see tony blabla", moves to the side and lets me in. The problem was Hans all along, not Tony availability angry. I still cant find where game even uses FACT_CONVO_HANS, grepping codebase finds only declaration and FACT_84_AND_85_TRUE in https://github.com/aimnas/ja2-1.13-source-mirror/blob/master/Strategic/Quests.cpp#L1235 , but nowhere else where it would be read/used.
this line
	if ( InARoom( gpSrcSoldier->sGridNo, &usRoom ) && (usRoom == gModSettings.usPornShopRoomHans) )
does look suspicious, because
gModSettings.usPornShopRoomHans = iniReader.ReadInteger("San Mona", "PORN_SHOP_ROOM_HANS", 49);
and 49 is the room directly behind Hans, Hans is standing in 46, brenda 47, Tony backroom is 50.
I tried creating Ja2_Options.INI
[San Mona]
PORN_SHOP_ROOM_HANS =
with 46 47 and 50 but nothing changed angry

Kitty wrote on Mon, 05 July 2021 20:23
in any case, it's used in Scripts/StrategicEventHandler.lua in HandleEarlyMorningEvents()
even more questions, why \Data\Scripts and \Data-1.13\Scripts contain duplicates of:

ExplosionControl.lua
HourlyUpdate.lua
initmines.lua
initunderground.lua
InterfaceDialogue.lua
Intro.lua
StrategicEventHandler.lua
undergroundsectornames.lua

I looked into those scripts and cant find anything touching FACT_CONVO_HANS. I even looked in https://github.com/ja2-stracciatella/ja2-stracciatella/search?q=FACT_84 codebase and still nothing. Hmm lets backtrack, Hans needs Brenda quest finished, lets look at Brenda.
aaand this is the moment I discover github search sucks
https://github.com/aimnas/ja2-1.13-source-mirror/search?q=brenda finds 12 occurrences (should be 17), somehow misses https://github.com/aimnas/ja2-1.13-source-mirror/blob/master/Tactical/Overhead.cpp#L3807 just great angry
Weird thing is I tried killing brenda, that wouldnt fix Hans letting me in before angry
Nevertheless The only thing I can find that changes is the TriggerNPCRecord( HANS, 10 ); if brenda is dead, or https://github.com/aimnas/ja2-1.13-source-mirror/blob/addff410229d5387e41b5c72b2b92c4b908b1b1e/Tactical/Interface%20Dial ogue.cpp#L4329
but afaik those only trigger dialogs by calling SpecialCharacterDialogueEventWithExtraParam and dont change any logic angry

Reproduction: https://file.io/1FQIkOXyQRDs got one merc, traveled to san mona, killed brenda. Hans is stuck on "tony stepped out". If you move to adjacent sector for a day and come back he will be stuck on "inventory talk". Wont let you in.
Now
CTRL-G, ALT+Q, ALT-T into the backroom and you can see Tony at his spot.
or
CTRL-G, F11, "pg facts down" button 3 times, click on 84 "Hans lets ou see Tony", set to 1, F11 to exit this menu, talk to Hans and ... first convo he lies "tony stepped out", but talking to him second time he lets you in and bug is fixed permanently.

[Updated on: Thu, 08 July 2021 19:32]

Previous Topic: Bugs: 2014 Official 1.13 Release (7435) with 7609 Update
Goto Forum:
  


Current Time: Fri Jul 23 18:43:31 EEST 2021

Total time taken to generate the page: 0.03527 seconds