Item class is now correct for the RPGs and the RPO. (GameDir 1880)

It seems that there is more problems then just ammo. Weapons placed on WF maps are incompatible with attachments. If you attach something you get sound, but attachment is removed. eg. a match sight I found in Omerta fit correctly on Glock 17 my IMP had, but it got deleted from the game when I tried to place it on M1911 I found in sector. Or 2x scope when I tried to place it on Ithaca 37 or on Type 85.

r6652 should fix this problem.

Unfortunatly the bug with random items remains even with exe 6641 on gamedir 1882:

If you don't save the map in vanilla map format and the random items haven't 268435456< (misc), they don't spawn the items in their lists properly.
Save them with vanilla map format unchecked and you end up with the plain random items, not the contents they should spawn. This happens regardless them having 268435456< (misc) or 1073741824< (random item).

So the map editor still isn't fully useable at the moment.

Doubt this is mapeditor problem, something is very wrong with those random items, whatever I try get results you described [.]

• exe 6520 on gamedir 1842: itemclass misc/save in vanilla format -> random item spawns listed items properly
• exe 6520 on gamedir 1842: itemclass random item/save in vanilla format -> random item spawns listed items properly
• exe 6520 on gamedir 1842: itemclass misc/don't save in in vanilla format -> random item spawns nothing

• exe 6534: itemclass misc/save in vanilla format -> random item doesn't even appear on the map
• exe 6534: itemclass misc/don't save in vanilla format -> random item spawns nothing
• exe 6534: itemclass random item/save in vanilla format -> random item doesn't even appear on the map
• exe 6534: itemclass random item/don't save in vanilla format -> random item spawns nothing

exe: 6655
gamedir:1882
Game freezes with automatic flagging on and off. What is weird is that character dosent say thing about trap when standing or walking next to that trap. The game freezes only when you try to walk on top of the trapped square.

@RoWa21

Ok, but then we need to put FileExist condition in ReadInSpreadPatterns function or better before calling ReadInSpreadPatterns to avoid VFS throwing unnecessary std exception.

6656/1884

at the beginning of the game Fatima does not lead mercs to Dimitri after moving to Omerta's right sector.

I gave her letter from Enrico, then moved to adjacent sector before her. she followed to the next sector but she is not showing rebel hideout
here save file
http://rghost.ru/50505520

Bug report:

6659 for Chinese Version

v1.13 mod throws VFS exception for missing file:
SPEECH\000_059.gap

Kriplo

v1.13 mod throws VFS exception for missing file:
SPEECH\000_059.gap

Can someone create the missing gap-file from the "000_059.wav" file and upload it?

Two issues regarding suppression calculation:
1) overhead.cpp CalcSuppressionTolerance()

bTolerance += pSoldier->GetSuppressionResistanceBonus();

is calculated after applying minimum and maximum suppresion tolerance values

bTolerance = __max(bTolerance, gGameExternalOptions.ubSuppressionToleranceMin);
bTolerance = __min(bTolerance, gGameExternalOptions.ubSuppressionToleranceMax);

This could lead to incorrect suppression tolerance values.
Changed this to

// Flugente: add personal bonus to suppresion tolerance
bTolerance += pSoldier->GetSuppressionResistanceBonus();

bTolerance = __max(bTolerance, gGameExternalOptions.ubSuppressionToleranceMin);
bTolerance = __min(bTolerance, gGameExternalOptions.ubSuppressionToleranceMax);

overhead.cpp patch r6663

2) values in backgrounds.xml are probably too excessive. Adding or deducting 10 or 20 from suppression tolerance (min 1, max 18) makes all other calculations rather meaningless.
So i suggest reducing this to appropriate values, as backgrounds are supposed to make very small changes to other systems.
I changed them to 1/5 of original values, so now Barry has -2 penalty to suppression tolerance instead of -10, because of his graduate background.
backgrounds.xml patch gamedir 1885
This change is subject to discussion. Maybe original values were supposed to be % penalties?

I tried to create the missing gap file with the tool "GAP File Editor", but it can't process the "000_059.WAV" file. It seems the wav-file has some settings that the tool can't read. Other wav files work fine...

Unfortunatly the bug with random items remains even with exe 6641 on gamedir 1882:

If you don't save the map in vanilla map format and the random items haven't 268435456< (misc), they don't spawn the items in their lists properly.
Save them with vanilla map format unchecked and you end up with the plain random items, not the contents they should spawn. This happens regardless them having 268435456< (misc) or 1073741824< (random item).

So the map editor still isn't fully useable at the moment.