Home » MODDING HQ 1.13 » v1.13 Bug Reports » BUGZILLA report all bugs here!
Re: BUGZILLA report all bugs here![message #324837] Sat, 07 September 2013 10:46 Go to previous messageGo to next message
wolf00 is currently offline wolf00

 
Messages:1148
Registered:September 2006
Location: Czech Republic

[URL=http://imageshack.com/i/mwyjr0j/]http://imageshack.com/a/img824/6384/yjr0.jpg

[URL=http://imageshack.com/i/f24vonj/]http://imageshack.com/a/img542/784/4von.jpg

[URL=http://imageshack.com/i/g9iv9ej/]http://imageshack.com/a/img585/7828/iv9e.jpg

Report message to a moderator

Sergeant Major
Re: BUGZILLA report all bugs here![message #324839] Sat, 07 September 2013 11:24 Go to previous messageGo to next message
Parkan is currently offline Parkan

 
Messages:438
Registered:April 2010
Location: Russia,Sevastopol

i think those bugs are for AFS mod not for vanilla mod?Post this in AFS topic.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324840] Sat, 07 September 2013 11:27 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
@wolf00

This could be related with new backgrounds.
CalcShopKeeperItemPrice function throw exception under debug as
uiDiscountValue variable is unset for guns and ammo.

Probably Flugente already work on it.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324842] Sat, 07 September 2013 11:33 Go to previous messageGo to next message
Elvis_A is currently offline Elvis_A

 
Messages:282
Registered:December 2012
Location: exUSSR
6358/1758
I saw the bug with negative prices in both Ja 1.13 and Arulco Folding Stock too.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324844] Sat, 07 September 2013 12:01 Go to previous messageGo to next message
DepressivesBrot is currently offline DepressivesBrot

 
Messages:3657
Registered:July 2009
Kriplo
@wolf00

This could be related with new backgrounds.
CalcShopKeeperItemPrice function throw exception under debug as
uiDiscountValue variable is unset for guns and ammo.

Probably Flugente already work on it.
You might want to fix this yourself, he's not even around for the next couple of weeks.

Report message to a moderator

Captain

Re: BUGZILLA report all bugs here![message #324845] Sat, 07 September 2013 12:22 Go to previous messageGo to next message
wolf00 is currently offline wolf00

 
Messages:1148
Registered:September 2006
Location: Czech Republic

no this is also present in sci 1753 6358.exe,no mods instaled on top

Report message to a moderator

Sergeant Major
Re: BUGZILLA report all bugs here![message #324848] Sat, 07 September 2013 14:34 Go to previous messageGo to next message
Buggler is currently offline Buggler

 
Messages:211
Registered:November 2009
@wolf00
Shopkeeper bug fix is already submitted before your reporting. Did not experience negative values in my testing though. Probably due to e uiDiscountValue variable being set before I started testing.

Due to unforeseen circumstances (Initially wanted Flugente to commit but with him being off to lala land), it has not yet been committed into SVN. Wait for Rowa's commit.

Treat it as another part of game's simulation: their calculators are temporarily experiencing their version of Y2K bug. In the meantime, live off your stash. Smile

Edit:
Committed in r6371 by silversurfer

[Updated on: Sun, 08 September 2013 04:52] by Moderator

Report message to a moderator

Sergeant 1st Class
Re: BUGZILLA report all bugs here![message #324854] Sat, 07 September 2013 15:47 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
Currently in build trunk still missing update for this exception, anyway will not update if Rowa21 already have fix.

If not check and add final else in function CalcShopKeeperItemPrice:

// if it's a GUN or AMMO (but not Launchers, and all attachments and payload is included)
if ( Item [ usItemID ].usItemClass & (IC_GUN|IC_AMMO) )
{
if ( gpSMCurrentMerc->GetBackgroundValue(BG_PERC_PRICES_GUNS) )
uiDiscountValue = ( uiItemPrice[ubCnt] * gpSMCurrentMerc->GetBackgroundValue(BG_PERC_PRICES_GUNS) ) / 100;
// if we play without backgrounds, Flo gets the hardcoded bonus
else if ( gpSMCurrentMerc->ubProfile == FLO )
uiDiscountValue = ( uiItemPrice[ubCnt] * FLO_DISCOUNT_PERCENTAGE ) / 100;
else//dnl Add this to fix unset value as this part is inside for loop
uiDiscountValue = 0;

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324858] Sat, 07 September 2013 16:27 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
I believe the best fix would be to initialize properly. Wink

So instead of:
UINT32	uiDiscountValue;

use:
UINT32	uiDiscountValue = 0;


edit: Fixed in 6371 together with Bugglers other bugfixes regarding shop and auto attachments.

[Updated on: Sat, 07 September 2013 17:19] by Moderator

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #324862] Sat, 07 September 2013 19:17 Go to previous messageGo to next message
Elvis_A is currently offline Elvis_A

 
Messages:282
Registered:December 2012
Location: exUSSR
Doctors in Cambria do not heal critical wounds. is it bug or intentional?

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324863] Sat, 07 September 2013 20:03 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
If there are no complains I will commit fix for NAS manipulation problem (reported by Buggler)described below:

- Fix problems with left click on NAS pocket with weapon and attachment in hand also do some patch to JA2SP_INVENTORY_AP inventory manipulation.

Details:
- If have valid attachment for weapon in some NAS pocket and try left click on it weapon will be transfered to HANDPOS, this is fix and attachment box will pop up instead.
- Fix problem with inventory manipulation on when they deduct APs from even on unsuccessful item movement.
- From now during turn based combat you can only attach and reload weapon in your HANDPOS and item handling is forbidden in strategic map as code for APs deduction for item movement is only implemented in tactical screen. So this restrictions apply only during turn based combat and with JA2SP_INVENTORY_AP is turned on.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324867] Sun, 08 September 2013 00:03 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
Wow, since the latest patches there is something very wrong with CTH calculation. My mercs and opponents can't hit anything anymore even at very close range. Investigating...

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #324868] Sun, 08 September 2013 00:13 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
You are playing OCTH or NCTH?
In OCTH I have no problems.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324870] Sun, 08 September 2013 00:24 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
NCTH. I already fixed it in 6373. The bug was introduced in rev 6363.

iSightRange was set to 0 after it had been calculated correctly.
After that everything was calculated with target invisible... *ouch* :dontlike:

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #324871] Sun, 08 September 2013 00:30 Go to previous messageGo to next message
Strohmann is currently offline Strohmann

 
Messages:287
Registered:August 2011
Location: Division Thought Crimes
Revision 1759/6371 exe:

When modifying LASER_PERFORMANCE_XYZ in CTHConstants.ini the value from in Items.xml gets used correctly, but the old incorrect tooltip for projection factor still gets displayed in the UDB.



[Updated on: Sun, 08 September 2013 00:32] by Moderator

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324873] Sun, 08 September 2013 00:37 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
Real fun, just test with XM-8 from 10 tiles with max aim depleted clip and hit nothing Smile
like in OCTH if put uiDiceRoll to 0.

Going to update your fix and try again.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324874] Sun, 08 September 2013 00:49 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
@silversurfer

Ok, it's better now, around 10% of hits from 10 tiles.

Want to check bullet moving, which variable in NCTH you set if want to hit always regardless of distance ?

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324875] Sun, 08 September 2013 01:03 Go to previous messageGo to next message
Moa is currently offline Moa

 
Messages:58
Registered:September 2013
remove the iSightRange assignment in #6584 aswell: iSightRange = 0;

(albeit it is stated in the log this was not commited by me btw.)

Report message to a moderator

Corporal
Re: BUGZILLA report all bugs here![message #324876] Sun, 08 September 2013 01:03 Go to previous messageGo to next message
Faalagorn is currently offline Faalagorn

 
Messages:154
Registered:February 2012
Location: Poland
Parkan
Something weird is going with music in game.The battle tracks can play only 5-15 second then they start from all over again.the win music after tactical battle never run,plus i got bug with win music 5 times win music played after autoresolve battle.what is shit happened with it?

Also, the main menu music starts over whether you go back from preferences option, and laptop music restarts whether you leave the laptop (r6373)

[Updated on: Sun, 08 September 2013 01:06] by Moderator

Report message to a moderator

Staff Sergeant
Re: BUGZILLA report all bugs here![message #324879] Sun, 08 September 2013 01:59 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
Strohmann
Revision 1759/6371 exe:

When modifying LASER_PERFORMANCE_XYZ in CTHConstants.ini the value from in Items.xml gets used correctly, but the old incorrect tooltip for projection factor still gets displayed in the UDB.

Not in my game. :headscratch:

http://img809.imageshack.us/img809/9379/byso.png



Moa
remove the iSightRange assignment in #6584 aswell: iSightRange = 0;

(albeit it is stated in the log this was not commited by me btw.)

Oh yes, thanks for the hint. Fixed in 6374. This was for OCTH btw.

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #324887] Sun, 08 September 2013 10:36 Go to previous messageGo to next message
Parkan is currently offline Parkan

 
Messages:438
Registered:April 2010
Location: Russia,Sevastopol

solved

[Updated on: Sun, 08 September 2013 13:13] by Moderator

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #324889] Sun, 08 September 2013 11:41 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
Please use 6374. This contains a bugfix for OCTH.

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #324900] Sun, 08 September 2013 21:54 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
Strohmann
Revision 1759/6371 exe:

When modifying LASER_PERFORMANCE_XYZ in CTHConstants.ini the value from in Items.xml gets used correctly, but the old incorrect tooltip for projection factor still gets displayed in the UDB.

The bug only affected the general tab for a weapon. I simply overlooked this. Fixed in 6379.

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #324920] Mon, 09 September 2013 10:20 Go to previous messageGo to next message
wanne (aka RoWa21) is currently offline wanne (aka RoWa21)

 
Messages:1961
Registered:October 2005
Location: Austria
@music bugs: This should now be fixed in Rev. 6381, because we restored the original music code. Once the music externalization works like it should, we will re-add them.

Report message to a moderator

Sergeant Major

Re: BUGZILLA report all bugs here![message #324921] Mon, 09 September 2013 11:11 Go to previous messageGo to next message
Faalagorn is currently offline Faalagorn

 
Messages:154
Registered:February 2012
Location: Poland
RoWa21
@music bugs: This should now be fixed in Rev. 6381, because we restored the original music code. Once the music externalization works like it should, we will re-add them.

ja2.exe works fine, but editscreen.cpp prevents MapEditor from compiling. In line 1614 change
MusicPlay( giMusicID, MUSIC_OLD_TYPE, FALSE );
to
MusicPlay( giMusicID );

Report message to a moderator

Staff Sergeant
Re: BUGZILLA report all bugs here![message #324924] Mon, 09 September 2013 12:08 Go to previous messageGo to next message
wanne (aka RoWa21) is currently offline wanne (aka RoWa21)

 
Messages:1961
Registered:October 2005
Location: Austria
@Faalagorn: Thanks, it is fixed now.

Report message to a moderator

Sergeant Major

Re: BUGZILLA report all bugs here![message #324977] Tue, 10 September 2013 16:55 Go to previous messageGo to next message
Elvis_A is currently offline Elvis_A

 
Messages:282
Registered:December 2012
Location: exUSSR
1761/6371
I've got weird bug I'venever seen before:
If you move items from lbe to sector in map view and assign them to tasks after some time removed items will appear in your lbe again.

edit. maybe it is due to professional thief background?

[Updated on: Tue, 10 September 2013 17:18] by Moderator

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #325010] Wed, 11 September 2013 11:51 Go to previous messageGo to next message
Faalagorn is currently offline Faalagorn

 
Messages:154
Registered:February 2012
Location: Poland
E1vS
edit. maybe it is due to professional thief background?

Yes, it's a feature Smile. Read the background description. Being kleptomaniac is a tough one.

Report message to a moderator

Staff Sergeant
Re: BUGZILLA report all bugs here![message #325012] Wed, 11 September 2013 11:58 Go to previous messageGo to next message
Faalagorn is currently offline Faalagorn

 
Messages:154
Registered:February 2012
Location: Poland
Bug: I don't know exactly when it's happens, but I'm pretty sure it's related to higher resolutions (I'm playing 1920x1080), but sometimes when I click any button in tactical screen, my screen goes down a bit. That includes end of turn button, dialogues, every confirmation screen etc. I'll post some more details If I'll nail this issue down. I'm playing on EXE: 6387, Data: 1763 + AFS: v4.48 Release Candidate 20130905. My current Ja2_Settings.INI and my Ja2_Options.INI (vsync is on among others)

Report message to a moderator

Staff Sergeant
Re: BUGZILLA report all bugs here![message #325034] Wed, 11 September 2013 15:47 Go to previous messageGo to next message
Parkan is currently offline Parkan

 
Messages:438
Registered:April 2010
Location: Russia,Sevastopol

where i can find 6387 exe?in derpi build there is only 6375 maximum exe.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #325035] Wed, 11 September 2013 15:55 Go to previous messageGo to next message
Deleted.

 
Messages:2662
Registered:December 2012
Location: Russian Federation
Parkan:
look here
from Faalagorn's signature
https://drive.google.com/folderview?id=0B6NEi4vM86_bUm1jc3pSNFNKM0k
or get a complier :=!

Report message to a moderator

Lieutenant

Re: BUGZILLA report all bugs here![message #325071] Thu, 12 September 2013 00:53 Go to previous messageGo to next message
Moa is currently offline Moa

 
Messages:58
Registered:September 2013
There is something wrong since the changes related to not enough APs to drop off an item attached to cursor.
Accessing Map inventory with couple of items takes longer to load. for 100 items its allready some seconds in debug build for 6394.
Also after autoresolve battle it takes forever to continue (because the items are accessed/dropped/merged here as well). There are around 300 items in that sector and it took around 4 minutes to continue.
random break during 'hang' after autoresolve:
Toggle Spoiler

This was not the case before rev.6367.
Note that the callstack above is just a random break, those functions are not compulsory bugged.
Somewhere inbetween those versions something went wrong.

Edit: loading sector inventory with 250 items in rev 6394 takes 14 seconds, in rev 6367 it takes 9 seconds. Both using debug versions with debugging on, no breakpoints.
Edit2: its caused by Bobby Ray's shippment. If there is one arrived but not yet opened this increases the loading time of any sector inventory.

[Updated on: Thu, 12 September 2013 03:39] by Moderator

Report message to a moderator

Corporal
Re: BUGZILLA report all bugs here![message #325117] Thu, 12 September 2013 21:12 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
Moa
This was not the case before rev.6367.
Note that the callstack above is just a random break, those functions are not compulsory bugged.
Somewhere inbetween those versions something went wrong.

Edit: loading sector inventory with 250 items in rev 6394 takes 14 seconds, in rev 6367 it takes 9 seconds. Both using debug versions with debugging on, no breakpoints.
Edit2: its caused by Bobby Ray's shippment. If there is one arrived but not yet opened this increases the loading time of any sector inventory.


Moa, are you sure problem rise from r6367 as my change in that revision was just expanding condition to check EnoughPoints function for reload, for which I don't see how could create such huge problem?
And this what you explain first notice playing LootFrag savegame (which you could find above) and that was before r6367.
Afraid this problem go far deeper with inventory handling Uh Oh

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #325120] Thu, 12 September 2013 21:55 Go to previous messageGo to next message
Moa is currently offline Moa

 
Messages:58
Registered:September 2013
its somewhere in between 6367 (ok) and 6394 (~40% longer loading). These are the only revisions I have compared with that savegame.

Strictly speaking the huge increase in loading time is caused by bobby ray's. But this different bug actually made the performance lost measureable. I will keep that save till weekend when testing some more revisions.

Report message to a moderator

Corporal
Re: BUGZILLA report all bugs here![message #325123] Thu, 12 September 2013 22:37 Go to previous messageGo to next message
Kriplo is currently offline Kriplo

 
Messages:256
Registered:February 2008
Location: Zagreb - Croatia
Not sure if related, but when testing with LootFrog savegame with 3xx items it only take 5s when try to open inventory in B13 with those items, and currently loaded map is D13 where my mercs are positioned.

There is another strange time loss when you open new weapon description box from strategic map (opening is also not momentary) and just left click on empty weapon slot game freeze for few moments.

Anyway it will be great if you or someone could improve performance under debugger.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #325126] Fri, 13 September 2013 00:36 Go to previous messageGo to next message
Faalagorn is currently offline Faalagorn

 
Messages:154
Registered:February 2012
Location: Poland
I'm not sure whether it's AFS or stock 1.13, but the log files keep telling me that "file "SPEECH\006_000.gap" does not exist". Can you take a look at it?

P.S. There are no visible effects in-game I noticed by far

Report message to a moderator

Staff Sergeant
Re: BUGZILLA report all bugs here![message #325139] Fri, 13 September 2013 10:04 Go to previous messageGo to next message
silversurfer

 
Messages:2793
Registered:May 2009
Faalagorn
I'm not sure whether it's AFS or stock 1.13, but the log files keep telling me that "file "SPEECH\006_000.gap" does not exist". Can you take a look at it?

P.S. There are no visible effects in-game I noticed by far


Isn't that a vanilla bug? I remember it from looooong ago.

Report message to a moderator

Lieutenant
Re: BUGZILLA report all bugs here![message #325161] Fri, 13 September 2013 19:54 Go to previous messageGo to next message
Elvis_A is currently offline Elvis_A

 
Messages:282
Registered:December 2012
Location: exUSSR
1773/6393

Encountered bug few times, alt+L, ctrl+L doesn't work, only alt+X.

I was trying to heal my mercs in the Cabria Hospital. Willis accepted my money and my mercs followed him. After that I see infinite clock and map view is blocked.

Report message to a moderator

Master Sergeant
Re: BUGZILLA report all bugs here![message #325164] Fri, 13 September 2013 22:07 Go to previous messageGo to next message
Moa is currently offline Moa

 
Messages:58
Registered:September 2013
Moa
its somewhere in between 6367 (ok) and 6394 (~40% longer loading). These are the only revisions I have compared with that savegame.

Strictly speaking the huge increase in loading time is caused by bobby ray's. But this different bug actually made the performance lost measureable. I will keep that save till weekend when testing some more revisions.


I am sorry, this was not true and I appologize for that quick assumtion. A more precise test showed that the loading times vary in a large range:

Toggle Spoiler


The difference between the versions is negligible.
I have a guess: there might be some racing condition -> gameloop was told to render inventory, inventory renders but in meantime the view got changed by some code:
BOOLEAN AutoPlaceObjectToWorld(SOLDIERTYPE * pSoldier, OBJECTTYPE * pObj, INT8 bVisible)
..
fShowMapInventoryPool = FALSE;
..

then the map screen gets rendered again by gameloop because it is not shown anymore

Might be totaly wrong, just a wild guess...

Edit:
identified a part of the long delay for opening the inventory, I will check the closing delay on Sunday.
But I have not figured out why there is such a huge increase when Bobby Ray has shipped something.
(do not commit, needs to be double checked by flugente, the debugging stuff in game loop needs to be removed and some more changes needs to be done):
Toggle Spoiler

[Updated on: Sat, 14 September 2013 07:30] by Moderator

Report message to a moderator

Corporal
Re: BUGZILLA report all bugs here![message #325165] Fri, 13 September 2013 22:31 Go to previous messageGo to previous message
silversurfer

 
Messages:2793
Registered:May 2009
It seems that the trigger group cannot be attached to anything in stock 1.13. :yikes:

I checked items.xml and the Trigger Group (item 1026) is defined as 256 and 256. According to AttachmentSlots.xml class 256 is "External Attachments 1". What is this supposed to be? I believe that the trigger group should be of class 128 "Internal Attachments". Am I correct?

Report message to a moderator

Lieutenant
Previous Topic: 1440x900 resolution bug.
Next Topic: Mine income adjustment range
Goto Forum:
  


Current Time: Tue Jul 16 16:22:29 GMT+3 2024

Total time taken to generate the page: 0.03638 seconds